@JoostK Hi, I'm still having this issue with a lib build with latest next versions:

• Angular 8.0.0-rc.5
• CLI 8.0.0-rc.4
• ng-packagr 5.2.0

Is that normal?

@cyrilletuzi you need to try the master builds; we have not been backporting ngcc changes to 8.0.0.
Try using https://github.com/angular/compiler-cli-builds as the yarn/npm target.

@petebacondarwin Thanks for your quick answer.

I'm not sure to understand: does it mean a library build with v8.0 won't be able to be compatible with Ivy?

Can you confirm what you are trying to do and what errors you are getting?
If you want to compile with ivy you need to use the master versions when compiling.
If you are generating a library for consumption by a project compiling with ivy then it ought to be fine to compile and publish it compiled as normal (not ivy) via v8.0.0.

@petebacondarwin

Steps to reproduce:

• git clone https://github.com/cyrilletuzi/angular-async-local-storage
• cd angular-async-local-storage
• git checkout v8beta
• npm ci
• npm run build (build the lib in normal mode)
• in projects/ivy/src/app/app.module.ts, add:

import { StorageModule } from '@ngx-pwa/local-storage';

@NgModule({
  imports: [
    BrowserModule,
    StorageModule.forRoot({
      IDBNoWrap: true,
    })
  ]
})
export class AppModule { }

• ./node_modules/.bin/ng serve ivy

Same error as in #29078:

ERROR in projects/ivy/src/app/app.module.ts(9,12): error TS-991010: Value at position 1 in the NgModule.importss of AppModule is not a reference: [object Object]

Works if I remove StorageModule.

@cyrilletuzi I am confused. I can't find StorageModule within @ngx-pwa/local-storage here: https://unpkg.com/@ngx-pwa/local-storage@8.0.0-beta.12/fesm5/ngx-pwa-local-storage.js

@JoostK beta.12 didn't contain the last code, the local npm run build do.

I've just published beta.13 if you need it.

It looks like you are trying to build an example app using ivy inside your library project? Is that right?
If so then you need to use a next version of Angular to do the build in that projects/ivy/src folder. I.E. you need to specify the correct version of @angular/compiler-cli and friends in https://github.com/cyrilletuzi/angular-async-local-storage/blob/master/projects/ngx-pwa/local-storage/package.json

@petebacondarwin master branch is indeed in v7, but as mentionned in the repro steps, you need to switch to v8beta branch, where the last Angular v8 next version is used.

It appears that the CLI's integration of ngcc is unable to resolve dist/@ngx-pwa/local-storage/package.json. It currently relies on require.resolve and some quick debugging session leaves me to believe that it only searches in node_modules folders, so the dist directory spoils the fun.

Here's how the package.json is resolved in @ngtools/webpack's integration of ngcc:

https://github.com/angular/angular-cli/blob/5df02a3de5257162c7b8a5e2c65d388debcd51f0/packages/ngtools/webpack/src/ngcc_processor.ts#L88-L105

@alan-agius4 do you see possibilities to alleviate this problem?

@cyrilletuzi - sorry I didn't spot that the git checkout v8beta was actually checking out a verison that builds with Angular master.

@alan-agius4 could jump in regarding the CLI integration. We do support, I believe dist folders but they need to be setup via the paths property in tsconfig.json, right?

@cyrilletuzi Running ngcc manually on dist using node_modules/.bin/ivy-ngcc -s ./dist lets me compile and serve the app successfully

@JoostK I confirm your debug: it works well in an external app, it's just a problem inside a local app.

When doing ng serve in an external app (another project with the lib installed via npm), the first time, I see the compiler doing this:

Compiling @angular/core : es2015 as esm2015
Compiling @angular/common : es2015 as esm2015
Compiling @angular/platform-browser : es2015 as esm2015
Compiling @angular/platform-browser-dynamic : es2015 as esm2015
Compiling @ngx-pwa/local-storage : es2015 as esm2015

But when doing ng serve in a local app (inside dist), I just see this (the lib is not compiled):

Compiling @angular/core : es2015 as esm2015
Compiling @angular/common : es2015 as esm2015
Compiling @angular/platform-browser : es2015 as esm2015
Compiling @angular/platform-browser-dynamic : es2015 as esm2015

@JoostK With your workaround, tests are now passing, thanks. So it's OK on my side. 👍

Hi all, the dist folder resolution is not yet implemented in the CLI, as this was done in angular master after the version 8 branch has been created. Hence it should be available in version 8.1

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}