fix(ivy): run annotations handlers' resolve() in ngcc#28963
fix(ivy): run annotations handlers' resolve() in ngcc#28963gkalpak wants to merge 7 commits intoangular:masterfrom
resolve() in ngcc#28963Conversation
|
|
There was a problem hiding this comment.
Looks like this breaks real-life - https://circleci.com/gh/angular/angular/220656 and https://circleci.com/gh/angular/angular/220659#tests/containers/2.
Also there is a minor linting issue.
407c9de to
709cd89
Compare
709cd89 to
05d5ef6
Compare
05d5ef6 to
76e4716
Compare
packages/compiler-cli/src/ngcc/test/analysis/decoration_analyzer_spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Perhaps this beforeEach and the following it clauses should be put in a describe block, otherwise we are running setupAndAnalyzeProgram() twice for the tests in `describe('internal components')
There was a problem hiding this comment.
Ha ha, yeah, I really wanted to do that, but couldn't come up with a good description 😇
I'll make something up 🤔
packages/compiler-cli/src/ngcc/test/analysis/decoration_analyzer_spec.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngcc/src/analysis/decoration_analyzer.ts
Outdated
Show resolved
Hide resolved
1167166 to
a38c314
Compare
|
You can preview 407c9de at https://pr28963-407c9de.ngbuilds.io/. |
|
You can preview a38c314 at https://pr28963-a38c314.ngbuilds.io/. |
The `resolve` phase (run after all handlers have analyzed) was introduced in 7d954df, but `ngcc` was not updated to run the handlers' `resolve()` methods. As a result, certain operations (such as listing directives used in component templates) would not be performed by `ngcc`. This commit fixes it by running the `resolve()` methods once analysis has been completed.
a38c314 to
778de01
Compare
|
You can preview 778de01 at https://pr28963-778de01.ngbuilds.io/. |
The `resolve` phase (run after all handlers have analyzed) was introduced in 7d954df, but `ngcc` was not updated to run the handlers' `resolve()` methods. As a result, certain operations (such as listing directives used in component templates) would not be performed by `ngcc`. This commit fixes it by running the `resolve()` methods once analysis has been completed. PR Close #28963
) The `resolve` phase (run after all handlers have analyzed) was introduced in 7d954df, but `ngcc` was not updated to run the handlers' `resolve()` methods. As a result, certain operations (such as listing directives used in component templates) would not be performed by `ngcc`. This commit fixes it by running the `resolve()` methods once analysis has been completed. PR Close angular#28963
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Docs have been added / updated (for bug fixes / features)PR Type
What is the current behavior?
The
resolvephase (run after all handlers have compiled) was introduced in 7d954df, butngccwas not updated to run the handlers'resolve()methods. As a result, certain operations (such as listing directives used in component templates) would not be performed byngcc.What is the new behavior?
This PR fixes it by running the
resolve()methods once compilation has been completed.Does this PR introduce a breaking change?
Other information
Jirs issue: FW-1149