Two @nocollapse related fixes for Ivy #28050
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngtsc has a hack to add @nocollapse jsdoc annotations to generated static fields. This hack is currently broken (likely due to a TypeScript change in the way writeFile() works). This commit fixes the hack and introduces an ngtsc_spec test to ensure it does not regress again.
vikerman
approved these changes
Jan 10, 2019
|
You can preview f67b62c at https://pr28050-f67b62c.ngbuilds.io/. |
__NG_ELEMENT_ID__ static fields are a part of how the Ivy node injector works. In order to survive closure minification correctly, they need to be annotated with @nocollapse.
|
You can preview ab79102 at https://pr28050-ab79102.ngbuilds.io/. |
Contributor
Contributor
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 11, 2019
…lds (#28050) __NG_ELEMENT_ID__ static fields are a part of how the Ivy node injector works. In order to survive closure minification correctly, they need to be annotated with @nocollapse. PR Close #28050
mhevery
added a commit
to mhevery/angular
that referenced
this pull request
Jan 12, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.