Skip to content

docs(ivy): Typo fix, ContentChildred => ContentChildren #23258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pankajparkar wants to merge 1 commit into from
Closed

docs(ivy): Typo fix, ContentChildred => ContentChildren #23258

pankajparkar wants to merge 1 commit into from

Conversation

@pankajparkar
Copy link

@pankajparkar pankajparkar commented Apr 9, 2018

This PR is made to correct typo Status.md page of Render3

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

@pankajparkar pankajparkar changed the title Typo fix, ContentChildred => ContentChildren docs(ivy): Typo fix, ContentChildred => ContentChildren Apr 9, 2018
@vicb vicb added action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Apr 9, 2018
@ngbot
Copy link

ngbot bot commented Apr 9, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: lint" is failing
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb vicb removed the action: merge The PR is ready for merge by the caretaker label Apr 9, 2018
@vicb
Copy link
Contributor

vicb commented Apr 9, 2018

Please fix the commit message (see CONTRIBUTING.md)

@pankajparkar pankajparkar reopened this Apr 10, 2018
@pankajparkar
Copy link
Author

pankajparkar commented Apr 10, 2018

@vicb can you please take a look at it again?

@pankajparkar
Copy link
Author

pankajparkar commented Apr 22, 2018

@vicb can you please some one look into this? It ready to merge.

@amitport amitport mentioned this pull request May 2, 2018
Closed
3 tasks
@theodorejb theodorejb mentioned this pull request May 17, 2018
Closed
3 tasks
@gkalpak gkalpak requested a review from vicb May 18, 2018 07:40
@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels May 18, 2018
@vicb vicb added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 30, 2018
@vicb
Copy link
Contributor

vicb commented May 30, 2018

fixed in #22888

@vicb vicb closed this May 30, 2018
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@vicb vicb vicb approved these changes

@gkalpak gkalpak gkalpak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pankajparkar @vicb @gkalpak @googlebot