Skip to content

docs(ivy): fix typo in STATUS.md #22888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aassaad wants to merge 2 commits into from
Closed

docs(ivy): fix typo in STATUS.md #22888

aassaad wants to merge 2 commits into from

Conversation

@aassaad
Copy link
Contributor

@aassaad aassaad commented Mar 20, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

has n typos, where n >= 1

What is the new behavior?

has n-1 typos

Does this PR introduce a breaking change?

[ ] Yes
[x] No

trotyl referenced this pull request Mar 22, 2018
@mhevery
docs(ivy): update status of ivy (#22834)
f258ec6 
PR Close #22834
@ngbot
Copy link

ngbot bot commented Mar 23, 2018

Hi @aassaad! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@IgorMinar IgorMinar added the area: core Issues related to the framework runtime label May 15, 2018
@ngbot
Copy link

ngbot bot commented May 30, 2018

Hi @aassaad! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@vicb vicb added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels May 30, 2018
@ngbot
Copy link

ngbot bot commented May 30, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure conflicts with base branch "master"
    failure missing required label: "PR target: *"
    failure status "ci/circleci: lint" is failing
    pending status "google3" is pending
    pending status "code-review/pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb
Copy link
Contributor

vicb commented May 30, 2018

needs rebase + commit title

@vicb vicb added the target: major This PR is targeted for the next major release label May 30, 2018
@vicb vicb mentioned this pull request May 30, 2018
Closed
@vicb
Copy link
Contributor

vicb commented May 30, 2018

merged into master

@vicb vicb closed this May 30, 2018
@jenniferfell jenniferfell added the state: community Someone from the Angular community is working on this issue or submitted this PR label Oct 9, 2018
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vicb vicb vicb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note state: community Someone from the Angular community is working on this issue or submitted this PR target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aassaad @vicb @matsko @IgorMinar @googlebot @jenniferfell