Skip to content

adev: Local packages not linked properly for development #54858

@devversion

Description

@devversion

Unlike with aio, adev only links top-level @angular/ packages to their npm archives from HEAD. Transitive dependencies are not properly updated, like we do for AIO— this means that adev may run with older versions of the Angular compiler because e.g. the CLI devkit would have their own transitive dependency.

This can cause subtle build issues when making changes in the compiler. We should investigate if this is still needed, but not throw away the effort put into AIO:

def link_local_packages(all_aio_deps):
"""Create targets needed for building AIO against local angular packages.
Creates targets that link Angular packages, as well as targets to be used
in place of any deps required to build and test AIO. These targets filter
out any transitive deps on the npm packages and must be used in place of
any original list of deps.
Use the helper `substitute_local_package_deps()` to translate a list of deps
to the equivalent "filtered" target that this rule creates.

Additional context: 6cc3256

Metadata

Metadata

Assignees

Labels

P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentarea: dev-infraIssues related to Angular's own dev infra (build, test, CI, releasing)area: docs-infraAngular.dev application and infrastructure

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions