Skip to content

error code beyond expected range #53433

@ducin

Description

@ducin

Which @angular/* package(s) are the source of the bug?

core

Is this a regression?

Yes

Description

As stated in errors.ts:

 * Error code ranges per package:
 *  - core (this package): 100-999
 *  - forms: 1000-1999
 *  - common: 2000-2999
 *  - animations: 3000-3999
 *  - router: 4000-4999
 *  - platform-browser: 5000-5500

The issue is that two errors (introduced in #50980) are breaking above ranges:

  RUNTIME_DEPS_INVALID_IMPORTED_TYPE = 1000,
  RUNTIME_DEPS_ORPHAN_COMPONENT = 1001,

(https://github.com/angular/angular/blob/main/packages/core/src/errors.ts#L120-L122)
as they relate to core package, whereas 1000-1999 are restricted to forms.

Moreover, error codes 1000 and 1001 already exist:

  // Structure validation errors (10xx)
  NO_CONTROLS = 1000,
  MISSING_CONTROL = 1001,
  MISSING_CONTROL_VALUE = 1002,

(https://github.com/angular/angular/blob/main/packages/forms/src/errors.ts#L16-L18)

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in (run ng version)

No response

Anything else?

Possible solution: restrict codes 950-999 to relate to:

  // Runtime dependency tracker errors (950-999 range)
  RUNTIME_DEPS_INVALID_IMPORTED_TYPE = 950,
  RUNTIME_DEPS_ORPHAN_COMPONENT = 951,

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentarea: coreIssues related to the framework runtimebughotlist: error messagesstate: has PR

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions