Duplicate call to createRenderer in ComponentFactory.create #47980
Description
Which @angular/* package(s) are the source of the bug?
core
Is this a regression?
No
Description
ComponentFactory.create code looks like calling the same function with the same parameters twice.
angular/packages/core/src/render3/component_ref.ts
Lines 166 to 174 in f70f50a
First at line 166 the renderer is created and assigned to
hostRenderer, then in falsy branch of ternary assignment hostRNode = rootSelectorOrNode it gets created again and passed as first argument of createElementNode at line 173.
Even if Renderer2 implementations are usually smart enough to cache renderers, there's always a (IMHO) useless repetition of the call, thus an unneeded access to cache map.
Strange thing is that it gets referenced correctly as first argument of locateHostElement call for truthy branch.
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in (run ng version)
No response
Anything else?
No response