fix(core): remove duplicated EMPTY_ARRAY constant#40991
fix(core): remove duplicated EMPTY_ARRAY constant#40991cexbrayat wants to merge 1 commit intoangular:masterfrom
Conversation
The codebase currently contains several `EMPTY_ARRAY` constants, and they can end up in the bundle of an application. A recent commit 6fbe219 tipped us off as it introduced several `noop` occurrences in the golden symbol files. After investigating with @petebacondarwin, we decided to remove the duplicated symbols. This probably shaves only a few bytes, but this commit removes the duplicated functions, by always using the one in `core/src/utils/empty`.
AndrewKushnir
left a comment
There was a problem hiding this comment.
LGTM, thanks for re-creating this PR @cexbrayat 👍
I've verified that the changes are the same as cabe8be that was reviewed and merged originally, so no further reviews are needed.
Will update g3 status once I have it.
Thank you.
|
@cexbrayat FYI presubmits look good, so I'm adding this PR to the merge queue. Thank you. |
|
Note to Caretaker: originally this change was submitted and rolled back due to g3 issues. g3 was updated as needed and recent TGP looks good. However it might make sense to sync this change individually to have an option of an easy rollback if needed. Thank you. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The codebase currently contains several
EMPTY_ARRAYconstants,and they can end up in the bundle of an application.
A recent commit 6fbe219 tipped us off
as it introduced several
noopoccurrences in the golden symbol files.What is the new behavior?
After investigating, we decided to remove the duplicated symbols.
This probably shaves only a few bytes,
but this commit removes the duplicated functions,
by always using the one in
core/src/utils/empty.Does this PR introduce a breaking change?
Other information
This is a followup to PR #40587 as @AndrewKushnir needed a fresh PR to land it (see #40587 (comment)).