refactor(core): Replace non-null assertion operator with property initialization (#39730)

kubk · atscott · commit 6fbe21941d7a · 2020-11-18T09:14:41.000-08:00
Reuse the `noop` function from the common utilities PR Close #39730
diff --git a/packages/core/src/application_init.ts b/packages/core/src/application_init.ts
@@ -6,9 +6,9 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {isPromise} from '../src/util/lang';
-
 import {Inject, Injectable, InjectionToken, Optional} from './di';
+import {isPromise} from './util/lang';
+import {noop} from './util/noop';
 
 
 /**
@@ -37,10 +37,8 @@ export const APP_INITIALIZER = new InjectionToken<Array<() => void>>('Applicatio
  */
 @Injectable()
 export class ApplicationInitStatus {
-  // TODO(issue/24571): remove '!'.
-  private resolve!: Function;
-  // TODO(issue/24571): remove '!'.
-  private reject!: Function;
+  private resolve = noop;
+  private reject = noop;
   private initialized = false;
   public readonly donePromise: Promise<any>;
   public readonly done = false;
diff --git a/packages/core/test/bundling/forms/bundle.golden_symbols.json b/packages/core/test/bundling/forms/bundle.golden_symbols.json
@@ -626,9 +626,6 @@
   {
     "name": "VERSION"
   },
-  {
-    "name": "ViewEngineTemplateRef"
-  },
   {
     "name": "VE_ViewContainerRef"
   },
@@ -644,6 +641,9 @@
   {
     "name": "ViewEncapsulation"
   },
+  {
+    "name": "ViewEngineTemplateRef"
+  },
   {
     "name": "ViewRef"
   },
@@ -1397,6 +1397,9 @@
   {
     "name": "noop"
   },
+  {
+    "name": "noop"
+  },
   {
     "name": "normalizeValidators"
   },
diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -845,9 +845,6 @@
   {
     "name": "VERSION"
   },
-  {
-    "name": "ViewEngineTemplateRef"
-  },
   {
     "name": "VE_ViewContainerRef"
   },
@@ -860,6 +857,9 @@
   {
     "name": "ViewEncapsulation"
   },
+  {
+    "name": "ViewEngineTemplateRef"
+  },
   {
     "name": "ViewRef"
   },
@@ -1721,6 +1721,9 @@
   {
     "name": "noop"
   },
+  {
+    "name": "noop"
+  },
   {
     "name": "normalizeQueryParams"
   },
diff --git a/packages/core/test/bundling/todo/bundle.golden_symbols.json b/packages/core/test/bundling/todo/bundle.golden_symbols.json
@@ -140,9 +140,6 @@
   {
     "name": "TodoStore"
   },
-  {
-    "name": "ViewEngineTemplateRef"
-  },
   {
     "name": "VE_ViewContainerRef"
   },
@@ -152,6 +149,9 @@
   {
     "name": "ViewEncapsulation"
   },
+  {
+    "name": "ViewEngineTemplateRef"
+  },
   {
     "name": "ViewRef"
   },

Original file line number	Diff line number	Diff line change
`@@ -626,9 +626,6 @@`
`626`	`626`	`{`
`627`	`627`	`"name": "VERSION"`
`628`	`628`	`},`
`629`		`- {`
`630`		`- "name": "ViewEngineTemplateRef"`
`631`		`- },`
`632`	`629`	`{`
`633`	`630`	`"name": "VE_ViewContainerRef"`
`634`	`631`	`},`
`@@ -644,6 +641,9 @@`
`644`	`641`	`{`
`645`	`642`	`"name": "ViewEncapsulation"`
`646`	`643`	`},`
	`644`	`+ {`
	`645`	`+ "name": "ViewEngineTemplateRef"`
	`646`	`+ },`
`647`	`647`	`{`
`648`	`648`	`"name": "ViewRef"`
`649`	`649`	`},`
`@@ -1397,6 +1397,9 @@`
`1397`	`1397`	`{`
`1398`	`1398`	`"name": "noop"`
`1399`	`1399`	`},`
	`1400`	`+ {`
	`1401`	`+ "name": "noop"`
	`1402`	`+ },`
`1400`	`1403`	`{`
`1401`	`1404`	`"name": "normalizeValidators"`
`1402`	`1405`	`},`
Original file line number	Diff line number	Diff line change
`@@ -845,9 +845,6 @@`
`845`	`845`	`{`
`846`	`846`	`"name": "VERSION"`
`847`	`847`	`},`
`848`		`- {`
`849`		`- "name": "ViewEngineTemplateRef"`
`850`		`- },`
`851`	`848`	`{`
`852`	`849`	`"name": "VE_ViewContainerRef"`
`853`	`850`	`},`
`@@ -860,6 +857,9 @@`
`860`	`857`	`{`
`861`	`858`	`"name": "ViewEncapsulation"`
`862`	`859`	`},`
	`860`	`+ {`
	`861`	`+ "name": "ViewEngineTemplateRef"`
	`862`	`+ },`
`863`	`863`	`{`
`864`	`864`	`"name": "ViewRef"`
`865`	`865`	`},`
`@@ -1721,6 +1721,9 @@`
`1721`	`1721`	`{`
`1722`	`1722`	`"name": "noop"`
`1723`	`1723`	`},`
	`1724`	`+ {`
	`1725`	`+ "name": "noop"`
	`1726`	`+ },`
`1724`	`1727`	`{`
`1725`	`1728`	`"name": "normalizeQueryParams"`
`1726`	`1729`	`},`
Original file line number	Diff line number	Diff line change
`@@ -140,9 +140,6 @@`
`140`	`140`	`{`
`141`	`141`	`"name": "TodoStore"`
`142`	`142`	`},`
`143`		`- {`
`144`		`- "name": "ViewEngineTemplateRef"`
`145`		`- },`
`146`	`143`	`{`
`147`	`144`	`"name": "VE_ViewContainerRef"`
`148`	`145`	`},`
`@@ -152,6 +149,9 @@`
`152`	`149`	`{`
`153`	`150`	`"name": "ViewEncapsulation"`
`154`	`151`	`},`
	`152`	`+ {`
	`153`	`+ "name": "ViewEngineTemplateRef"`
	`154`	`+ },`
`155`	`155`	`{`
`156`	`156`	`"name": "ViewRef"`
`157`	`157`	`},`