refactor(animations): optimize resolveTimeExpression (#62927)

amilajack · crisbeto · commit fd373f2dddb4 · 2025-08-06T15:09:19.000+02:00
This moves a regexp expression into a const to optimize performance. PR Close #62927
diff --git a/packages/animations/browser/src/util.ts b/packages/animations/browser/src/util.ts
@@ -65,17 +65,18 @@ export function resolveTiming(
     : parseTimeExpression(<string | number>timings, errors, allowNegativeValues);
 }
 
+const PARSE_TIME_EXPRESSION_REGEX =
+  /^(-?[\.\d]+)(m?s)(?:\s+(-?[\.\d]+)(m?s))?(?:\s+([-a-z]+(?:\(.+?\))?))?$/i;
 function parseTimeExpression(
   exp: string | number,
   errors: Error[],
   allowNegativeValues?: boolean,
 ): AnimateTimings {
-  const regex = /^(-?[\.\d]+)(m?s)(?:\s+(-?[\.\d]+)(m?s))?(?:\s+([-a-z]+(?:\(.+?\))?))?$/i;
   let duration: number;
   let delay: number = 0;
   let easing: string = '';
   if (typeof exp === 'string') {
-    const matches = exp.match(regex);
+    const matches = exp.match(PARSE_TIME_EXPRESSION_REGEX);
     if (matches === null) {
       errors.push(invalidTimingValue(exp));
       return {duration: 0, delay: 0, easing: ''};
diff --git a/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json b/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json
@@ -192,6 +192,7 @@
       "OperatorSubscriber",
       "PARAM_REGEX",
       "PARENT",
+      "PARSE_TIME_EXPRESSION_REGEX",
       "PLATFORM_BROWSER_ID",
       "PLATFORM_DESTROY_LISTENERS",
       "PLATFORM_ID",
