fix(platform-server): decouple server from animations module (#59762)

crisbeto · alxhub · commit fc5d187da5e8 · 2025-01-29T10:52:18.000-08:00
Removes the hard dependency between `platform-server` and `platform-browser/animations` since now the animations module will disable itself automatically. PR Close #59762
diff --git a/goldens/public-api/platform-server/index.api.md b/goldens/public-api/platform-server/index.api.md
@@ -7,8 +7,7 @@
 import { ApplicationRef } from '@angular/core';
 import { EnvironmentProviders } from '@angular/core';
 import * as i0 from '@angular/core';
-import * as i1 from '@angular/platform-browser/animations';
-import * as i2 from '@angular/platform-browser';
+import * as i1 from '@angular/platform-browser';
 import { InjectionToken } from '@angular/core';
 import { PlatformRef } from '@angular/core';
 import { Provider } from '@angular/core';
@@ -66,7 +65,7 @@ export class ServerModule {
     // (undocumented)
     static ɵinj: i0.ɵɵInjectorDeclaration<ServerModule>;
     // (undocumented)
-    static ɵmod: i0.ɵɵNgModuleDeclaration<ServerModule, never, [typeof i1.NoopAnimationsModule], [typeof i2.BrowserModule]>;
+    static ɵmod: i0.ɵɵNgModuleDeclaration<ServerModule, never, never, [typeof i1.BrowserModule]>;
 }
 
 // @public (undocumented)
diff --git a/goldens/public-api/platform-server/testing/index.api.md b/goldens/public-api/platform-server/testing/index.api.md
@@ -5,8 +5,7 @@
 ```ts
 
 import * as i0 from '@angular/core';
-import * as i1 from '@angular/platform-browser/animations';
-import * as i2 from '@angular/platform-browser-dynamic/testing';
+import * as i1 from '@angular/platform-browser-dynamic/testing';
 import { PlatformRef } from '@angular/core';
 import { StaticProvider } from '@angular/core';
 
@@ -20,7 +19,7 @@ export class ServerTestingModule {
     // (undocumented)
     static ɵinj: i0.ɵɵInjectorDeclaration<ServerTestingModule>;
     // (undocumented)
-    static ɵmod: i0.ɵɵNgModuleDeclaration<ServerTestingModule, never, [typeof i1.NoopAnimationsModule], [typeof i2.BrowserDynamicTestingModule]>;
+    static ɵmod: i0.ɵɵNgModuleDeclaration<ServerTestingModule, never, never, [typeof i1.BrowserDynamicTestingModule]>;
 }
 
 // (No @packageDocumentation comment for this package)
diff --git a/packages/platform-server/BUILD.bazel b/packages/platform-server/BUILD.bazel
@@ -15,13 +15,11 @@ ng_module(
     ),
     deps = [
         ":bundled_domino_lib",
-        "//packages/animations/browser",
         "//packages/common",
         "//packages/common/http",
         "//packages/compiler",
         "//packages/core",
         "//packages/platform-browser",
-        "//packages/platform-browser/animations",
         "//packages/zone.js/lib:zone_d_ts",
         "@npm//@types/node",
         "@npm//rxjs",
diff --git a/packages/platform-server/package.json b/packages/platform-server/package.json
@@ -8,7 +8,6 @@
     "node": "^18.19.1 || ^20.11.1 || >=22.0.0"
   },
   "peerDependencies": {
-    "@angular/animations": "0.0.0-PLACEHOLDER",
     "@angular/common": "0.0.0-PLACEHOLDER",
     "@angular/compiler": "0.0.0-PLACEHOLDER",
     "@angular/core": "0.0.0-PLACEHOLDER",
diff --git a/packages/platform-server/src/provide_server.ts b/packages/platform-server/src/provide_server.ts
@@ -7,7 +7,6 @@
  */
 
 import {EnvironmentProviders, makeEnvironmentProviders} from '@angular/core';
-import {provideNoopAnimations} from '@angular/platform-browser/animations';
 
 import {PLATFORM_SERVER_PROVIDERS} from './server';
 
@@ -31,5 +30,5 @@ export function provideServerRendering(): EnvironmentProviders {
     globalThis['ngServerMode'] = true;
   }
 
-  return makeEnvironmentProviders([provideNoopAnimations(), ...PLATFORM_SERVER_PROVIDERS]);
+  return makeEnvironmentProviders([...PLATFORM_SERVER_PROVIDERS]);
 }
diff --git a/packages/platform-server/src/server.ts b/packages/platform-server/src/server.ts
@@ -35,7 +35,6 @@ import {
   EVENT_MANAGER_PLUGINS,
   ɵBrowserDomAdapter as BrowserDomAdapter,
 } from '@angular/platform-browser';
-import {NoopAnimationsModule} from '@angular/platform-browser/animations';
 
 import {DominoAdapter, parseDocument} from './domino_adapter';
 import {SERVER_HTTP_PROVIDERS} from './http';
@@ -90,7 +89,6 @@ export const PLATFORM_SERVER_PROVIDERS: Provider[] = [
  */
 @NgModule({
   exports: [BrowserModule],
-  imports: [NoopAnimationsModule],
   providers: PLATFORM_SERVER_PROVIDERS,
 })
 export class ServerModule {}
diff --git a/packages/platform-server/testing/BUILD.bazel b/packages/platform-server/testing/BUILD.bazel
@@ -10,7 +10,6 @@ ng_module(
     deps = [
         "//packages/core",
         "//packages/platform-browser-dynamic/testing",
-        "//packages/platform-browser/animations",
         "//packages/platform-server",
     ],
 )
diff --git a/packages/platform-server/testing/src/server.ts b/packages/platform-server/testing/src/server.ts
@@ -11,7 +11,6 @@ import {
   BrowserDynamicTestingModule,
   ɵplatformCoreDynamicTesting as platformCoreDynamicTesting,
 } from '@angular/platform-browser-dynamic/testing';
-import {NoopAnimationsModule} from '@angular/platform-browser/animations';
 import {
   ɵINTERNAL_SERVER_PLATFORM_PROVIDERS as INTERNAL_SERVER_PLATFORM_PROVIDERS,
   ɵSERVER_RENDER_PROVIDERS as SERVER_RENDER_PROVIDERS,
@@ -35,7 +34,6 @@ export const platformServerTesting = createPlatformFactory(
  */
 @NgModule({
   exports: [BrowserDynamicTestingModule],
-  imports: [NoopAnimationsModule],
   providers: SERVER_RENDER_PROVIDERS,
 })
 export class ServerTestingModule {}

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,6 @@`
`7`	`7`	`*/`
`8`	`8`
`9`	`9`	`import {EnvironmentProviders, makeEnvironmentProviders} from '@angular/core';`
`10`		`-import {provideNoopAnimations} from '@angular/platform-browser/animations';`
`11`	`10`
`12`	`11`	`import {PLATFORM_SERVER_PROVIDERS} from './server';`
`13`	`12`
`@@ -31,5 +30,5 @@ export function provideServerRendering(): EnvironmentProviders {`
`31`	`30`	`globalThis['ngServerMode'] = true;`
`32`	`31`	`}`
`33`	`32`
`34`		`- return makeEnvironmentProviders([provideNoopAnimations(), ...PLATFORM_SERVER_PROVIDERS]);`
	`33`	`+ return makeEnvironmentProviders([...PLATFORM_SERVER_PROVIDERS]);`
`35`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@ ng_module(`
`10`	`10`	`deps = [`
`11`	`11`	`"//packages/core",`
`12`	`12`	`"//packages/platform-browser-dynamic/testing",`
`13`		`- "//packages/platform-browser/animations",`
`14`	`13`	`"//packages/platform-server",`
`15`	`14`	`],`
`16`	`15`	`)`