Skip to content

Commit eb9a5f5

Browse files
ci: Add primitives groups to pullapprove (#53404)
This adds the shared primitives reviewers groups and list of reviewers to the pullapprove rules. PR Close #53404
1 parent 158ceaf commit eb9a5f5

2 files changed

Lines changed: 77 additions & 1 deletion

File tree

.pullapprove.yml

Lines changed: 76 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ groups:
193193
<<: *defaults
194194
conditions:
195195
- >
196-
contains_any_globs(files.exclude("packages/core/schematics/*"), [
196+
contains_any_globs(files.exclude("packages/core/schematics/*").exclude('packages/core/primitives/*'), [
197197
'packages/core/**/{*,.*}',
198198
'packages/examples/core/**/{*,.*}',
199199
'packages/platform-browser/**/{*,.*}',
@@ -1321,6 +1321,81 @@ groups:
13211321
- jessicajaniuk
13221322
- josephperrott
13231323

1324+
# =========================================================
1325+
# Primitives
1326+
# =========================================================
1327+
1328+
# Angular team required reviews
1329+
primitives:
1330+
<<: *defaults
1331+
conditions:
1332+
- >
1333+
contains_any_globs(files, [
1334+
'packages/core/primitives/**/{*,.*}',
1335+
])
1336+
reviewers:
1337+
users:
1338+
- pkozlowski-opensource # Pawel Kozlowski
1339+
- alxhub # Alex Rickabaugh
1340+
- jessicajaniuk # Jessica Janiuk
1341+
- dylhunn # Dylan Hunn
1342+
- AndrewKushnir # Andrew Kushnir
1343+
- atscott # Andrew Scott
1344+
reviews:
1345+
required: 1
1346+
reviewed_for: required
1347+
labels:
1348+
pending: 'requires: TGP'
1349+
approved: 'requires: TGP'
1350+
rejected: 'requires: TGP'
1351+
1352+
# External team required reviews
1353+
primitives-shared:
1354+
<<: *defaults
1355+
conditions:
1356+
- >
1357+
contains_any_globs(files, [
1358+
'packages/core/primitives/**/{*,.*}',
1359+
])
1360+
reviewers:
1361+
users:
1362+
- csmick # Cameron Smick
1363+
- lannka # Hongfei Ding
1364+
- eduhmc # Eduardo Huerta-Mercado
1365+
- ehlemur # Edward Lesmes
1366+
- ellenyuan # Ellen Yuan
1367+
- jatraman # Jatin Ramanathan
1368+
- jesse-good # Jesse Costello-Good
1369+
- mturco # Matt Turco
1370+
- neonstalwart # Ben Hockey
1371+
- nicholasyu-google # Nicholas Yu
1372+
- rahatarmanahmed # Rahat Ahmed
1373+
- emspishak # Eric Spishak-Thomas
1374+
reviews:
1375+
required: 1
1376+
reviewed_for: required
1377+
labels:
1378+
pending: 'requires: TGP'
1379+
approved: 'requires: TGP'
1380+
rejected: 'requires: TGP'
1381+
1382+
# External team required reviews
1383+
primitives-jsaction:
1384+
<<: *defaults
1385+
conditions:
1386+
- >
1387+
contains_any_globs(files, [
1388+
'packages/core/primitives/jsaction/**/{*,.*}',
1389+
])
1390+
reviewers:
1391+
users:
1392+
- iteriani # Thomas Nguyen
1393+
- tbondwilkinson # Tom Wilkinson
1394+
- rahatarmanahmed # Rahat Ahmed
1395+
reviews:
1396+
required: 1
1397+
reviewed_for: required
1398+
13241399
####################################################################################
13251400
# Override managed result groups
13261401
#
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
# TBD

0 commit comments

Comments
 (0)