refactor(core): remove circular dep in ViewRef definition (#59083)

alxhub · alxhub · commit d0e0446149b7 · 2024-12-05T16:01:15.000-08:00
Use `import type` to break a phantom circular import in the runtime definition of `ViewRef`. PR Close #59083
diff --git a/goldens/circular-deps/packages.json b/goldens/circular-deps/packages.json
@@ -1,8 +1,4 @@
 [
-  [
-    "packages/core/src/change_detection/change_detector_ref.ts",
-    "packages/core/src/render3/view_ref.ts"
-  ],
   [
     "packages/core/src/change_detection/differs/default_iterable_differ.ts",
     "packages/core/src/change_detection/differs/iterable_differs.ts"
diff --git a/packages/core/src/render3/view_ref.ts b/packages/core/src/render3/view_ref.ts
@@ -6,11 +6,11 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {ChangeDetectorRef} from '../change_detection/change_detector_ref';
+import type {ChangeDetectorRef} from '../change_detection/change_detector_ref';
 import {NotificationSource} from '../change_detection/scheduling/zoneless_scheduling';
 import type {ApplicationRef} from '../core';
 import {RuntimeError, RuntimeErrorCode} from '../errors';
-import {EmbeddedViewRef} from '../linker/view_ref';
+import type {EmbeddedViewRef} from '../linker/view_ref';
 import {removeFromArray} from '../util/array_utils';
 import {assertEqual} from '../util/assert';
 

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,4 @@`
`1`	`1`	`[`
`2`		`- [`
`3`		`- "packages/core/src/change_detection/change_detector_ref.ts",`
`4`		`- "packages/core/src/render3/view_ref.ts"`
`5`		`- ],`
`6`	`2`	`[`
`7`	`3`	`"packages/core/src/change_detection/differs/default_iterable_differ.ts",`
`8`	`4`	`"packages/core/src/change_detection/differs/iterable_differs.ts"`