refactor(core): remove circular dep in iterable differs. (#59083)

alxhub · alxhub · commit c9ce08a7ea02 · 2024-12-05T16:01:15.000-08:00
Use `import type` to break a phantom circular import in iterable differs. PR Close #59083
diff --git a/goldens/circular-deps/packages.json b/goldens/circular-deps/packages.json
@@ -1,12 +1,4 @@
 [
-  [
-    "packages/core/src/change_detection/differs/default_iterable_differ.ts",
-    "packages/core/src/change_detection/differs/iterable_differs.ts"
-  ],
-  [
-    "packages/core/src/change_detection/differs/default_keyvalue_differ.ts",
-    "packages/core/src/change_detection/differs/keyvalue_differs.ts"
-  ],
   [
     "packages/core/src/di/injectable.ts",
     "packages/core/src/di/jit/injectable.ts"
diff --git a/packages/core/src/change_detection/differs/default_iterable_differ.ts b/packages/core/src/change_detection/differs/default_iterable_differ.ts
@@ -11,7 +11,7 @@ import {Writable} from '../../interface/type';
 import {isListLikeIterable, iterateListLike} from '../../util/iterable';
 import {stringify} from '../../util/stringify';
 
-import {
+import type {
   IterableChangeRecord,
   IterableChanges,
   IterableDiffer,
diff --git a/packages/core/src/change_detection/differs/default_keyvalue_differ.ts b/packages/core/src/change_detection/differs/default_keyvalue_differ.ts
@@ -10,7 +10,7 @@ import {RuntimeError, RuntimeErrorCode} from '../../errors';
 import {isJsObject} from '../../util/iterable';
 import {stringify} from '../../util/stringify';
 
-import {
+import type {
   KeyValueChangeRecord,
   KeyValueChanges,
   KeyValueDiffer,

Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,4 @@`
`1`	`1`	`[`
`2`		`- [`
`3`		`- "packages/core/src/change_detection/differs/default_iterable_differ.ts",`
`4`		`- "packages/core/src/change_detection/differs/iterable_differs.ts"`
`5`		`- ],`
`6`		`- [`
`7`		`- "packages/core/src/change_detection/differs/default_keyvalue_differ.ts",`
`8`		`- "packages/core/src/change_detection/differs/keyvalue_differs.ts"`
`9`		`- ],`
`10`	`2`	`[`
`11`	`3`	`"packages/core/src/di/injectable.ts",`
`12`	`4`	`"packages/core/src/di/jit/injectable.ts"`