Skip to content

Commit c87e581

Browse files
mmalerbaatscott
authored andcommitted
fix(core): Don't run effects in check no changes pass (#59455) (#59551)
This reverts commit 21f1ba2. PR Close #59551
1 parent 730fe65 commit c87e581

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

packages/core/src/render3/instructions/change_detection.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,9 @@ function detectChangesInView(lView: LView, mode: ChangeDetectionMode) {
498498
if (shouldRefreshView) {
499499
refreshView(tView, lView, tView.template, lView[CONTEXT]);
500500
} else if (flags & LViewFlags.HasChildViewsToRefresh) {
501-
runEffectsInView(lView);
501+
if (!isInCheckNoChangesPass) {
502+
runEffectsInView(lView);
503+
}
502504
detectChangesInEmbeddedViews(lView, ChangeDetectionMode.Targeted);
503505
const components = tView.components;
504506
if (components !== null) {

0 commit comments

Comments
 (0)