fix(language-service): use type-only import in plugin factory (#55996)

crisbeto · dylhunn · commit b7f2fd473988 · 2024-05-22T09:52:33.000-07:00
Fixes that the plugin factory was causing TypeScript to be bundled into the language service. PR Close #55996
diff --git a/packages/language-service/plugin-factory.ts b/packages/language-service/plugin-factory.ts
@@ -6,7 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import ts from 'typescript';
+// Note: use a type-only import to prevent TypeScript from being bundled in.
+import type ts from 'typescript';
 
 import {NgLanguageService, PluginConfig} from './api';
 
@@ -24,7 +25,7 @@ export const factory: ts.server.PluginModuleFactory = (tsModule): PluginModule =
       return plugin.create(info);
     },
     getExternalFiles(project: ts.server.Project): string[] {
-      return plugin?.getExternalFiles?.(project, ts.ProgramUpdateLevel.Full) ?? [];
+      return plugin?.getExternalFiles?.(project, tsModule.typescript.ProgramUpdateLevel.Full) ?? [];
     },
     onConfigurationChanged(config: PluginConfig): void {
       plugin?.onConfigurationChanged?.(config);
