refactor(core): drop ViewRefTracker in favor of ApplicationRef. (#58096)

JeanMeche · AndrewKushnir · commit 9ca9db4f746a · 2024-10-08T13:25:24.000-07:00
We can leverage an `import type` to prevent the circular import. PR Close #58096
diff --git a/packages/core/src/linker/view_ref.ts b/packages/core/src/linker/view_ref.ts
@@ -100,13 +100,3 @@ export abstract class EmbeddedViewRef<C> extends ViewRef {
    */
   abstract get rootNodes(): any[];
 }
-
-/**
- * Interface for tracking root `ViewRef`s in `ApplicationRef`.
- *
- * NOTE: Importing `ApplicationRef` here directly creates circular dependency, which is why we have
- * a subset of the `ApplicationRef` interface `ViewRefTracker` here.
- */
-export interface ViewRefTracker {
-  detachView(viewRef: ViewRef): void;
-}
diff --git a/packages/core/src/render3/view_ref.ts b/packages/core/src/render3/view_ref.ts
@@ -8,8 +8,9 @@
 
 import {ChangeDetectorRef} from '../change_detection/change_detector_ref';
 import {NotificationSource} from '../change_detection/scheduling/zoneless_scheduling';
+import type {ApplicationRef} from '../core';
 import {RuntimeError, RuntimeErrorCode} from '../errors';
-import {EmbeddedViewRef, ViewRefTracker} from '../linker/view_ref';
+import {EmbeddedViewRef} from '../linker/view_ref';
 import {removeFromArray} from '../util/array_utils';
 import {assertEqual} from '../util/assert';
 
@@ -43,7 +44,7 @@ import {storeLViewOnDestroy, updateAncestorTraversalFlagsOnAttach} from './util/
 interface ChangeDetectorRefInterface extends ChangeDetectorRef {}
 
 export class ViewRef<T> implements EmbeddedViewRef<T>, ChangeDetectorRefInterface {
-  private _appRef: ViewRefTracker | null = null;
+  private _appRef: ApplicationRef | null = null;
   private _attachedToViewContainer = false;
 
   get rootNodes(): any[] {
@@ -349,7 +350,7 @@ export class ViewRef<T> implements EmbeddedViewRef<T>, ChangeDetectorRefInterfac
     detachViewFromDOM(this._lView[TVIEW], this._lView);
   }
 
-  attachToAppRef(appRef: ViewRefTracker) {
+  attachToAppRef(appRef: ApplicationRef) {
     if (this._attachedToViewContainer) {
       throw new RuntimeError(
         RuntimeErrorCode.VIEW_ALREADY_ATTACHED,
