refactor(core): remove circular dep in ComponentFactoryResolver (#59083)

alxhub · alxhub · commit 98471dfc0839 · 2024-12-05T16:01:15.000-08:00
Use `import type` to break a phantom circular import in the runtime definition of `ComponentFactory` and `ComponentFactoryResolver`. PR Close #59083
diff --git a/goldens/circular-deps/packages.json b/goldens/circular-deps/packages.json
@@ -1,9 +1,4 @@
 [
-  [
-    "packages/core/src/linker/component_factory_resolver.ts",
-    "packages/core/src/linker/component_factory.ts",
-    "packages/core/src/linker/ng_module_factory.ts"
-  ],
   [
     "packages/core/src/metadata/directives.ts",
     "packages/core/src/render3/jit/directive.ts"
diff --git a/packages/core/src/linker/component_factory.ts b/packages/core/src/linker/component_factory.ts
@@ -6,14 +6,14 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {ChangeDetectorRef} from '../change_detection/change_detection';
-import {Injector} from '../di/injector';
-import {EnvironmentInjector} from '../di/r3_injector';
+import type {ChangeDetectorRef} from '../change_detection/change_detection';
+import type {Injector} from '../di/injector';
+import type {EnvironmentInjector} from '../di/r3_injector';
 import {Type} from '../interface/type';
 
-import {ElementRef} from './element_ref';
-import {NgModuleRef} from './ng_module_factory';
-import {ViewRef} from './view_ref';
+import type {ElementRef} from './element_ref';
+import type {NgModuleRef} from './ng_module_factory';
+import type {ViewRef} from './view_ref';
 
 /**
  * Represents a component created by a `ComponentFactory`.
diff --git a/packages/core/src/linker/component_factory_resolver.ts b/packages/core/src/linker/component_factory_resolver.ts
@@ -9,7 +9,7 @@
 import {Type} from '../interface/type';
 import {stringify} from '../util/stringify';
 
-import {ComponentFactory} from './component_factory';
+import type {ComponentFactory} from './component_factory';
 
 class _NullComponentFactoryResolver implements ComponentFactoryResolver {
   resolveComponentFactory<T>(component: {new (...args: any[]): T}): ComponentFactory<T> {

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,4 @@`
`1`	`1`	`[`
`2`		`- [`
`3`		`- "packages/core/src/linker/component_factory_resolver.ts",`
`4`		`- "packages/core/src/linker/component_factory.ts",`
`5`		`- "packages/core/src/linker/ng_module_factory.ts"`
`6`		`- ],`
`7`	`2`	`[`
`8`	`3`	`"packages/core/src/metadata/directives.ts",`
`9`	`4`	`"packages/core/src/render3/jit/directive.ts"`