refactor(core): remove circular dep in JIT decorator definitions (#59083)

alxhub · alxhub · commit 8bc3693f7ae6 · 2024-12-05T16:01:15.000-08:00
Use `import type` to break phantom circular imports in the runtime definitions of JIT decorators. PR Close #59083
diff --git a/goldens/circular-deps/packages.json b/goldens/circular-deps/packages.json
@@ -1,26 +1,4 @@
 [
-  [
-    "packages/core/src/metadata/directives.ts",
-    "packages/core/src/render3/jit/directive.ts"
-  ],
-  [
-    "packages/core/src/metadata/directives.ts",
-    "packages/core/src/render3/jit/directive.ts",
-    "packages/core/src/metadata/resource_loading.ts"
-  ],
-  [
-    "packages/core/src/metadata/directives.ts",
-    "packages/core/src/render3/jit/directive.ts",
-    "packages/core/src/render3/jit/module.ts"
-  ],
-  [
-    "packages/core/src/metadata/directives.ts",
-    "packages/core/src/render3/jit/pipe.ts"
-  ],
-  [
-    "packages/core/src/metadata/ng_module.ts",
-    "packages/core/src/render3/jit/module.ts"
-  ],
   [
     "packages/core/src/render3/interfaces/container.ts",
     "packages/core/src/render3/interfaces/view.ts"
diff --git a/packages/core/src/metadata/resource_loading.ts b/packages/core/src/metadata/resource_loading.ts
@@ -8,7 +8,7 @@
 
 import {Type} from '../interface/type';
 
-import {Component} from './directives';
+import type {Component} from './directives';
 
 /**
  * Used to resolve resource URLs on `@Component` when used with JIT compilation.
diff --git a/packages/core/src/render3/jit/directive.ts b/packages/core/src/render3/jit/directive.ts
@@ -18,8 +18,8 @@ import {
 import {resolveForwardRef} from '../../di/forward_ref';
 import {getReflect, reflectDependencies} from '../../di/jit/util';
 import {Type} from '../../interface/type';
-import {Query} from '../../metadata/di';
-import {Component, Directive, Input} from '../../metadata/directives';
+import type {Query} from '../../metadata/di';
+import type {Component, Directive, Input} from '../../metadata/directives';
 import {
   componentNeedsResolution,
   maybeQueueResolutionOfComponentResources,
diff --git a/packages/core/src/render3/jit/module.ts b/packages/core/src/render3/jit/module.ts
@@ -13,13 +13,16 @@ import {
 } from '../../compiler/compiler_facade';
 import {resolveForwardRef} from '../../di/forward_ref';
 import {NG_INJ_DEF} from '../../di/interface/defs';
-import {ModuleWithProviders} from '../../di/interface/provider';
+import type {ModuleWithProviders} from '../../di/interface/provider';
 import {reflectDependencies} from '../../di/jit/util';
 import {Type} from '../../interface/type';
 import {registerNgModuleType} from '../../linker/ng_module_registration';
-import {Component} from '../../metadata/directives';
-import {NgModule} from '../../metadata/ng_module';
-import {NgModuleDef, NgModuleTransitiveScopes, NgModuleType} from '../../metadata/ng_module_def';
+import type {NgModule} from '../../metadata/ng_module';
+import type {
+  NgModuleDef,
+  NgModuleTransitiveScopes,
+  NgModuleType,
+} from '../../metadata/ng_module_def';
 import {deepForEach, flatten} from '../../util/array_utils';
 import {assertDefined} from '../../util/assert';
 import {EMPTY_ARRAY} from '../../util/empty';
@@ -33,7 +36,7 @@ import {
 } from '../def_getters';
 import {depsTracker, USE_RUNTIME_DEPS_TRACKER_FOR_JIT} from '../deps_tracker/deps_tracker';
 import {NG_COMP_DEF, NG_DIR_DEF, NG_FACTORY_DEF, NG_MOD_DEF, NG_PIPE_DEF} from '../fields';
-import {ComponentDef} from '../interfaces/definition';
+import type {ComponentDef} from '../interfaces/definition';
 import {maybeUnwrapFn} from '../util/misc_utils';
 import {stringifyForError} from '../util/stringify_utils';
 
diff --git a/packages/core/src/render3/jit/pipe.ts b/packages/core/src/render3/jit/pipe.ts
@@ -13,7 +13,7 @@ import {
 } from '../../compiler/compiler_facade';
 import {reflectDependencies} from '../../di/jit/util';
 import {Type} from '../../interface/type';
-import {Pipe} from '../../metadata/directives';
+import type {Pipe} from '../../metadata/directives';
 import {NG_FACTORY_DEF, NG_PIPE_DEF} from '../fields';
 
 import {angularCoreEnv} from './environment';
