refactor(core): remove circular dep in DI code (#59083)

alxhub · alxhub · commit 850a2ad8998e · 2024-12-05T16:01:15.000-08:00
Use `import type` to break a phantom circular import in the DI code. PR Close #59083
diff --git a/goldens/circular-deps/packages.json b/goldens/circular-deps/packages.json
@@ -1,8 +1,4 @@
 [
-  [
-    "packages/core/src/di/injectable.ts",
-    "packages/core/src/di/jit/injectable.ts"
-  ],
   [
     "packages/core/src/linker/component_factory_resolver.ts",
     "packages/core/src/linker/component_factory.ts",
diff --git a/packages/core/src/di/jit/injectable.ts b/packages/core/src/di/jit/injectable.ts
@@ -15,7 +15,7 @@ import {Type} from '../../interface/type';
 import {NG_FACTORY_DEF} from '../../render3/fields';
 import {getClosureSafeProperty} from '../../util/property';
 import {resolveForwardRef} from '../forward_ref';
-import {Injectable} from '../injectable';
+import type {Injectable} from '../injectable';
 import {NG_PROV_DEF} from '../interface/defs';
 import {
   ClassSansProvider,

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,4 @@`
`1`	`1`	`[`
`2`		`- [`
`3`		`- "packages/core/src/di/injectable.ts",`
`4`		`- "packages/core/src/di/jit/injectable.ts"`
`5`		`- ],`
`6`	`2`	`[`
`7`	`3`	`"packages/core/src/linker/component_factory_resolver.ts",`
`8`	`4`	`"packages/core/src/linker/component_factory.ts",`