Revert "fix(core): render hooks should not specifically run outside the Angular zone (#55399)" (#55624)

atscott · AndrewKushnir · commit 760e284428d8 · 2024-05-02T11:00:34.000-07:00
This reverts commit 7e89753. Running render hooks inside the zone is specifically problematic for `afterRender` hooks. If the callback has async task, it would cause an infinite change detection. In addition, updating state in render hooks is generally discourages and certainly should update state in a way that notifies Angular of the change (either via signal or with `markForCheck`) rather than relying on ZoneJS to pick it up (which would only work if the change is done inside an async task). PR Close #55624
diff --git a/packages/core/src/render3/after_render_hooks.ts b/packages/core/src/render3/after_render_hooks.ts
@@ -331,6 +331,7 @@ export function afterNextRender(
  * A wrapper around a function to be used as an after render callback.
  */
 class AfterRenderCallback {
+  private zone = inject(NgZone);
   private errorHandler = inject(ErrorHandler, {optional: true});
 
   constructor(readonly phase: AfterRenderPhase, private callbackFn: VoidFunction) {
@@ -340,7 +341,7 @@ class AfterRenderCallback {
 
   invoke() {
     try {
-      this.callbackFn();
+      this.zone.runOutsideAngular(this.callbackFn);
     } catch (err) {
       this.errorHandler?.handleError(err);
     }
