refactor(migrations): typos in signal migration incompatibility reasons (#58636)

cexbrayat · thePunderWoman · commit 715caea46b4c · 2024-11-14T14:55:04.000Z
A dot was appearing in the middle of the comment for `DerivedIsIncompatible`. While at it, a dot was missing in `ClassManuallyInstantiated`. PR Close #58636
diff --git a/packages/core/schematics/migrations/signal-migration/src/passes/problematic_patterns/incompatibility_human.ts b/packages/core/schematics/migrations/signal-migration/src/passes/problematic_patterns/incompatibility_human.ts
@@ -50,7 +50,7 @@ export function getMessageForFieldIncompatibility(
           `This ${fieldName.single} is used in combination with \`@HostBinding\` and ` +
           `migrating would break.`,
         extra:
-          `\`@HostBinding\` does not invoke the signal automatically and your code would. ` +
+          `\`@HostBinding\` does not invoke the signal automatically and your code would ` +
           `break after migration. Use \`host\` of \`@Directive\`/\`@Component\`for host bindings.`,
       };
     case FieldIncompatibilityReason.PotentiallyNarrowedInTemplateButNoSupportYet:
@@ -144,7 +144,7 @@ export function getMessageForClassIncompatibility(
       return {
         short:
           `Class of this ${fieldName.single} is manually instantiated. ` +
-          'This is discouraged and prevents migration',
+          'This is discouraged and prevents migration.',
         extra:
           `Signal ${fieldName.plural} require a DI injection context. Manually instantiating ` +
           'breaks this requirement in some cases, so the migration is skipped.',
diff --git a/packages/core/schematics/migrations/signal-migration/test/golden.txt b/packages/core/schematics/migrations/signal-migration/test/golden.txt
@@ -827,7 +827,7 @@ import {Component, Input} from '@angular/core';
 export class ManualInstantiation {
   // TODO: Skipped for migration because:
   //  Class of this input is manually instantiated. This is discouraged and prevents
-  //  migration
+  //  migration.
   @Input() bla: string = '';
 }
 @@@@@@ modifier_tests.ts @@@@@@

Original file line number	Diff line number	Diff line change
`@@ -827,7 +827,7 @@ import {Component, Input} from '@angular/core';`
`827`	`827`	`export class ManualInstantiation {`
`828`	`828`	`// TODO: Skipped for migration because:`
`829`	`829`	`// Class of this input is manually instantiated. This is discouraged and prevents`
`830`		`- // migration`
	`830`	`+ // migration.`
`831`	`831`	`@Input() bla: string = '';`
`832`	`832`	`}`
`833`	`833`	`@@@@@@ modifier_tests.ts @@@@@@`