Skip to content

Commit 6ae07ad

Browse files
tsc036pkozlowski-opensource
authored andcommitted
refactor(core): Delete createSignalTuple (#61907)
Delete createSignalTuple because it is no longer needed. creatSignal has the same behavior. PR Close #61907
1 parent 0d198f2 commit 6ae07ad

File tree

4 files changed

+0
-35
lines changed

4 files changed

+0
-35
lines changed

goldens/public-api/core/primitives/signals/index.api.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@ export function createLinkedSignal<S, D>(sourceFn: () => S, computationFn: Compu
4343
// @public
4444
export function createSignal<T>(initialValue: T, equal?: ValueEqualityFn<T>): [SignalGetter<T>, SignalSetter<T>, SignalUpdater<T>];
4545

46-
// @public @deprecated
47-
export function createSignalTuple<T>(initialValue: T, equal?: ValueEqualityFn<T>): [SignalGetter<T>, SignalSetter<T>, SignalUpdater<T>];
48-
4946
// @public (undocumented)
5047
export function createWatch(fn: (onCleanup: WatchCleanupRegisterFn) => void, schedule: (watch: Watch) => void, allowSignalWrites: boolean): Watch;
5148

packages/core/primitives/signals/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ export {
5151
signalGetFn,
5252
signalSetFn,
5353
signalUpdateFn,
54-
createSignalTuple,
5554
} from './src/signal';
5655
export {Watch, WatchCleanupFn, WatchCleanupRegisterFn, createWatch} from './src/watch';
5756
export {setAlternateWeakRefImpl} from './src/weak_ref';

packages/core/primitives/signals/src/signal.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -72,17 +72,6 @@ export function createSignal<T>(
7272
return [getter, set, update];
7373
}
7474

75-
/**
76-
* Creates a `Signal` getter, setter, and updater function.
77-
* @deprecated use createSignal
78-
*/
79-
export function createSignalTuple<T>(
80-
initialValue: T,
81-
equal?: ValueEqualityFn<T>,
82-
): [SignalGetter<T>, SignalSetter<T>, SignalUpdater<T>] {
83-
return createSignal(initialValue, equal);
84-
}
85-
8675
export function setPostSignalSetFn(fn: ReactiveHookFn | null): ReactiveHookFn | null {
8776
const prev = postSignalSetFn;
8877
postSignalSetFn = fn;

packages/core/test/signals/signal_spec.ts

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {
1212
ReactiveNode,
1313
setPostProducerCreatedFn,
1414
setPostSignalSetFn,
15-
createSignalTuple,
1615
SIGNAL,
1716
} from '../../primitives/signals';
1817

@@ -226,22 +225,3 @@ describe('signals', () => {
226225
setPostProducerCreatedFn(prev);
227226
});
228227
});
229-
230-
describe('createSignalTuple', () => {
231-
it('get returns the signal value', () => {
232-
const [get] = createSignalTuple(0);
233-
expect(get()).toBe(0);
234-
});
235-
236-
it('set sets the signal value', () => {
237-
const [get, set] = createSignalTuple(0);
238-
set(1);
239-
expect(get()).toBe(1);
240-
});
241-
242-
it('update updates the values based on the previous value', () => {
243-
const [get, , update] = createSignalTuple(0);
244-
update((prev) => prev + 2);
245-
expect(get()).toBe(2);
246-
});
247-
});

0 commit comments

Comments
 (0)