fix(core): avoid slow stringification when checking for duplicates in dev mode (#58521)

crisbeto · pkozlowski-opensource · commit 5f2d98a1b126 · 2024-11-06T13:02:35.000+01:00
When we check for duplicates in dev mode, we end up stringifying an `LView` even if we don't report an error. This can be expensive in large views. These changes work around the issue by only generating the string when we have an error to throw. Fixes #58509. PR Close #58521
diff --git a/packages/core/src/render3/list_reconciliation.ts b/packages/core/src/render3/list_reconciliation.ts
@@ -8,7 +8,6 @@
 
 import {TrackByFunction} from '../change_detection';
 import {formatRuntimeError, RuntimeErrorCode} from '../errors';
-import {assertNotSame} from '../util/assert';
 
 import {stringifyForError} from './util/stringify_utils';
 
@@ -428,8 +427,12 @@ export class UniqueValueMultiKeyMap<K, V> {
   set(key: K, value: V): void {
     if (this.kvMap.has(key)) {
       let prevValue = this.kvMap.get(key)!;
-      ngDevMode &&
-        assertNotSame(prevValue, value, `Detected a duplicated value ${value} for the key ${key}`);
+
+      // Note: we don't use `assertNotSame`, because the value needs to be stringified even if
+      // there is no error which can freeze the browser for large values (see #58509).
+      if (ngDevMode && prevValue === value) {
+        throw new Error(`Detected a duplicated value ${value} for the key ${key}`);
+      }
 
       if (this._vMap === undefined) {
         this._vMap = new Map();
