refactor(core): improve stringify (#59745)

arturovt · thePunderWoman · commit 354b1fa22f77 · 2025-02-19T15:21:37.000Z
In this commit, we improve branching in the `stringify` function, which is widely used by the framework, and add additional comments for clarification. Benchmark results of the old and new implementations (using `slice` makes it slightly faster) are as follows: ``` stringify (old version) x 117,945,419 ops/sec ±5.25% (55 runs sampled) stringify (new version) x 136,692,820 ops/sec ±4.82% (56 runs sampled) ``` PR Close #59745
diff --git a/packages/core/src/util/stringify.ts b/packages/core/src/util/stringify.ts
@@ -12,29 +12,26 @@ export function stringify(token: any): string {
   }
 
   if (Array.isArray(token)) {
-    return '[' + token.map(stringify).join(', ') + ']';
+    return `[${token.map(stringify).join(', ')}]`;
   }
 
   if (token == null) {
     return '' + token;
   }
 
-  if (token.overriddenName) {
-    return `${token.overriddenName}`;
+  const name = token.overriddenName || token.name;
+  if (name) {
+    return `${name}`;
   }
 
-  if (token.name) {
-    return `${token.name}`;
-  }
-
-  const res = token.toString();
+  const result = token.toString();
 
-  if (res == null) {
-    return '' + res;
+  if (result == null) {
+    return '' + result;
   }
 
-  const newLineIndex = res.indexOf('\n');
-  return newLineIndex === -1 ? res : res.substring(0, newLineIndex);
+  const newLineIndex = result.indexOf('\n');
+  return newLineIndex >= 0 ? result.slice(0, newLineIndex) : result;
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -12,29 +12,26 @@ export function stringify(token: any): string {`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`if (Array.isArray(token)) {`
`15`		`- return '[' + token.map(stringify).join(', ') + ']';`
	`15`	+ return `[${token.map(stringify).join(', ')}]`;
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`if (token == null) {`
`19`	`19`	`return '' + token;`
`20`	`20`	`}`
`21`	`21`
`22`		`- if (token.overriddenName) {`
`23`		- return `${token.overriddenName}`;
	`22`	`+ const name = token.overriddenName \|\| token.name;`
	`23`	`+ if (name) {`
	`24`	+ return `${name}`;
`24`	`25`	`}`
`25`	`26`
`26`		`- if (token.name) {`
`27`		- return `${token.name}`;
`28`		`- }`
`29`		`-`
`30`		`- const res = token.toString();`
	`27`	`+ const result = token.toString();`
`31`	`28`
`32`		`- if (res == null) {`
`33`		`- return '' + res;`
	`29`	`+ if (result == null) {`
	`30`	`+ return '' + result;`
`34`	`31`	`}`
`35`	`32`
`36`		`- const newLineIndex = res.indexOf('\n');`
`37`		`- return newLineIndex === -1 ? res : res.substring(0, newLineIndex);`
	`33`	`+ const newLineIndex = result.indexOf('\n');`
	`34`	`+ return newLineIndex >= 0 ? result.slice(0, newLineIndex) : result;`
`38`	`35`	`}`
`39`	`36`
`40`	`37`	`/**`