refactor(core): remove circular dep in LView & LContainer definitions (#59083)

alxhub · alxhub · commit 308950dafa4d · 2024-12-05T16:01:15.000-08:00
Use `import type` to break phantom circular imports in the runtime definitions of `LView` and `LContainer`. PR Close #59083
diff --git a/goldens/circular-deps/packages.json b/goldens/circular-deps/packages.json
@@ -1,8 +1,4 @@
 [
-  [
-    "packages/core/src/render3/interfaces/container.ts",
-    "packages/core/src/render3/interfaces/view.ts"
-  ],
   [
     "packages/router/src/directives/router_outlet.ts",
     "packages/router/src/router_outlet_context.ts"
diff --git a/packages/core/src/render3/interfaces/view.ts b/packages/core/src/render3/interfaces/view.ts
@@ -13,11 +13,10 @@ import {ProviderToken} from '../../di/provider_token';
 import {DehydratedView} from '../../hydration/interfaces';
 import {SchemaMetadata} from '../../metadata/schema';
 import {Sanitizer} from '../../sanitization/sanitizer';
-import type {AfterRenderManager} from '../after_render/manager';
 import type {ReactiveLViewConsumer} from '../reactive_lview_consumer';
 import type {ViewEffectNode} from '../reactivity/effect';
 
-import {LContainer} from './container';
+import type {LContainer} from './container';
 import {
   ComponentDef,
   ComponentTemplate,

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,4 @@`
`1`	`1`	`[`
`2`		`- [`
`3`		`- "packages/core/src/render3/interfaces/container.ts",`
`4`		`- "packages/core/src/render3/interfaces/view.ts"`
`5`		`- ],`
`6`	`2`	`[`
`7`	`3`	`"packages/router/src/directives/router_outlet.ts",`
`8`	`4`	`"packages/router/src/router_outlet_context.ts"`