fix(core): error if NgZone.isInAngularZone is called with a noop zone (#44800)

crisbeto · AndrewKushnir · commit 215db7fbe6c9 · 2022-01-24T10:44:43.000-08:00
When the user opts into the noop `NgZone`, they usually still interact with the static methods on the non-noop class. This change adds a check to handle the case where zone.js hasn't been loaded. Fixes #44784. PR Close #44800
diff --git a/packages/core/src/zone/ng_zone.ts b/packages/core/src/zone/ng_zone.ts
@@ -153,7 +153,8 @@ export class NgZone {
   }
 
   static isInAngularZone(): boolean {
-    return Zone.current.get('isAngularZone') === true;
+    // Zone needs to be checked, because this method might be called even when NoopNgZone is used.
+    return typeof Zone !== 'undefined' && Zone.current.get('isAngularZone') === true;
   }
 
   static assertInAngularZone(): void {

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,8 @@ export class NgZone {`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`static isInAngularZone(): boolean {`
`156`		`- return Zone.current.get('isAngularZone') === true;`
	`156`	`+ // Zone needs to be checked, because this method might be called even when NoopNgZone is used.`
	`157`	`+ return typeof Zone !== 'undefined' && Zone.current.get('isAngularZone') === true;`
`157`	`158`	`}`
`158`	`159`
`159`	`160`	`static assertInAngularZone(): void {`