build: remove irrelevant madge circular deps tests (#61209)

devversion · alxhub · commit 1312eb160064 · 2025-05-08T09:23:47.000-07:00
We don't need this tooling anymore because we are already validating that there are no circular dependencies via the `ng-dev` tooling that checks `.ts` files directly. Also these tests never actually failed to my knowledge. PR Close #61209
diff --git a/.aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx b/.aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx
@@ -2,7 +2,7 @@
 # Input hashes for repository rule npm_translate_lock(name = "npm2", pnpm_lock = "@//:pnpm-lock.yaml").
 # This file should be checked into version control along with the pnpm-lock.yaml file.
 .npmrc=-203833057
-package.json=921559287
-pnpm-lock.yaml=-1557050076
+package.json=-2010611265
+pnpm-lock.yaml=1052846975
 pnpm-workspace.yaml=1711114604
-yarn.lock=-1169566608
+yarn.lock=1217123358
diff --git a/.pullapprove.yml b/.pullapprove.yml
@@ -336,7 +336,6 @@ groups:
           'scripts/**/{*,.*}',
           'third_party/**/{*,.*}',
           'tools/bazel-repo-patches/**/{*,.*}',
-          'tools/circular_dependency_test/**/{*,.*}',
           'tools/contributing-stats/**/{*,.*}',
           'tools/esm-interop/**/{*,.*}',
           'tools/gulp-tasks/**/{*,.*}',
diff --git a/package.json b/package.json
@@ -213,7 +213,6 @@
     "karma-jasmine-html-reporter": "^2.1.0",
     "karma-sauce-launcher": "^4.3.6",
     "live-server": "^1.2.2",
-    "madge": "^8.0.0",
     "marked": "^15.0.0",
     "mermaid": "^11.0.0",
     "patch-package": "^7.0.0",
diff --git a/packages/animations/browser/test/BUILD.bazel b/packages/animations/browser/test/BUILD.bazel
@@ -1,17 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/animations/browser/index.mjs",
-    deps = ["//packages/animations/browser"],
-)
-
-circular_dependency_test(
-    name = "testing_circular_deps_test",
-    entry_point = "angular/packages/animations/browser/testing/index.mjs",
-    deps = ["//packages/animations/browser/testing"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/animations/test/BUILD.bazel b/packages/animations/test/BUILD.bazel
@@ -1,13 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/animations/index.mjs",
-    deps = [
-        "//packages/animations",
-    ],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/common/http/test/BUILD.bazel b/packages/common/http/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/common/http/index.mjs",
-    deps = ["//packages/common/http"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/common/http/testing/test/BUILD.bazel b/packages/common/http/testing/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/common/http/testing/index.mjs",
-    deps = ["//packages/common/http/testing"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/common/test/BUILD.bazel b/packages/common/test/BUILD.bazel
@@ -1,17 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/common/index.mjs",
-    deps = ["//packages/common"],
-)
-
-circular_dependency_test(
-    name = "testing_circular_deps_test",
-    entry_point = "angular/packages/common/testing/index.mjs",
-    deps = ["//packages/common/testing"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/common/upgrade/test/BUILD.bazel b/packages/common/upgrade/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/common/upgrade/index.mjs",
-    deps = ["//packages/common/upgrade"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/compiler/test/BUILD.bazel b/packages/compiler/test/BUILD.bazel
@@ -1,18 +1,11 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
 
 # Test that should only be run in node
 NODE_ONLY = [
     "**/*_node_only_spec.ts",
     "aot/**/*.ts",
 ]
 
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/compiler/index.mjs",
-    deps = ["//packages/compiler"],
-)
-
 ts_library(
     name = "test_lib",
     testonly = True,
diff --git a/packages/core/rxjs-interop/test/BUILD.bazel b/packages/core/rxjs-interop/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/core/rxjs-interop/index.mjs",
-    deps = ["//packages/core/rxjs-interop"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/core/test/BUILD.bazel b/packages/core/test/BUILD.bazel
@@ -1,20 +1,7 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
 
 package(default_visibility = ["//visibility:public"])
 
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/core/index.mjs",
-    deps = ["//packages/core"],
-)
-
-circular_dependency_test(
-    name = "testing_circular_deps_test",
-    entry_point = "angular/packages/core/testing/index.mjs",
-    deps = ["//packages/core/testing"],
-)
-
 genrule(
     name = "downleveled_es5_fixture",
     srcs = ["reflection/es2015_inheritance_fixture.ts"],
diff --git a/packages/elements/test/BUILD.bazel b/packages/elements/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/elements/index.mjs",
-    deps = ["//packages/elements"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/forms/test/BUILD.bazel b/packages/forms/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "karma_web_test_suite", "ts_library", "zone_compatible_jasmine_node_test")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/forms/index.mjs",
-    deps = ["//packages/forms"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/localize/test/BUILD.bazel b/packages/localize/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/localize/index.mjs",
-    deps = ["//packages/localize"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/platform-browser-dynamic/test/BUILD.bazel b/packages/platform-browser-dynamic/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/platform-browser-dynamic/index.mjs",
-    deps = ["//packages/platform-browser-dynamic"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/platform-browser/animations/async/test/BUILD.bazel b/packages/platform-browser/animations/async/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/platform-browser/animations/index.mjs",
-    deps = ["//packages/platform-browser/animations"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/platform-browser/animations/test/BUILD.bazel b/packages/platform-browser/animations/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/platform-browser/animations/index.mjs",
-    deps = ["//packages/platform-browser/animations"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/platform-browser/test/BUILD.bazel b/packages/platform-browser/test/BUILD.bazel
@@ -1,24 +1,11 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
 load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
 
 exports_files([
     "browser/static_assets/200.html",
     "static_assets/test.html",
 ])
 
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/platform-browser/index.mjs",
-    deps = ["//packages/platform-browser"],
-)
-
-circular_dependency_test(
-    name = "testing_circular_deps_test",
-    entry_point = "angular/packages/platform-browser/testing/index.mjs",
-    deps = ["//packages/platform-browser/testing"],
-)
-
 ts_library(
     name = "test_lib",
     testonly = True,
diff --git a/packages/platform-server/init/test/BUILD.bazel b/packages/platform-server/init/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/platform-server/init/index.mjs",
-    deps = ["//packages/platform-server/init"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/platform-server/test/BUILD.bazel b/packages/platform-server/test/BUILD.bazel
@@ -1,17 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/platform-server/index.mjs",
-    deps = ["//packages/platform-server"],
-)
-
-circular_dependency_test(
-    name = "testing_circular_deps_test",
-    entry_point = "angular/packages/platform-server/testing/index.mjs",
-    deps = ["//packages/platform-server/testing"],
-)
 
 ts_library(
     name = "dom_utils",
diff --git a/packages/router/test/BUILD.bazel b/packages/router/test/BUILD.bazel
@@ -1,17 +1,4 @@
 load("//tools:defaults.bzl", "karma_web_test_suite", "ts_library", "zone_compatible_jasmine_node_test")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/router/index.mjs",
-    deps = ["//packages/router"],
-)
-
-circular_dependency_test(
-    name = "testing_circular_deps_test",
-    entry_point = "angular/packages/router/testing/index.mjs",
-    deps = ["//packages/router/testing"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/router/upgrade/test/BUILD.bazel b/packages/router/upgrade/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/router/upgrade/index.mjs",
-    deps = ["//packages/router/upgrade"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/service-worker/config/test/BUILD.bazel b/packages/service-worker/config/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/service-worker/config/index.mjs",
-    deps = ["//packages/service-worker/config"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/service-worker/test/BUILD.bazel b/packages/service-worker/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/service-worker/index.mjs",
-    deps = ["//packages/service-worker"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/service-worker/worker/test/BUILD.bazel b/packages/service-worker/worker/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/service-worker/worker/main.mjs",
-    deps = ["//packages/service-worker/worker:main"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/upgrade/src/common/test/BUILD.bazel b/packages/upgrade/src/common/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/upgrade/index.mjs",
-    deps = ["//packages/upgrade"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/upgrade/static/test/BUILD.bazel b/packages/upgrade/static/test/BUILD.bazel
@@ -1,11 +1,4 @@
 load("//tools:defaults.bzl", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
-
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/upgrade/static/index.mjs",
-    deps = ["//packages/upgrade/static"],
-)
 
 ts_library(
     name = "test_lib",
diff --git a/packages/upgrade/static/testing/test/BUILD.bazel b/packages/upgrade/static/testing/test/BUILD.bazel
@@ -1,14 +1,7 @@
 load("//tools:defaults.bzl", "karma_web_test_suite", "ts_library")
-load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
 
 package(default_visibility = ["//visibility:public"])
 
-circular_dependency_test(
-    name = "circular_deps_test",
-    entry_point = "angular/packages/upgrade/static/testing/index.mjs",
-    deps = ["//packages/upgrade/static/testing"],
-)
-
 ts_library(
     name = "test_lib",
     testonly = True,
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/tools/circular_dependency_test/BUILD.bazel b/tools/circular_dependency_test/BUILD.bazel
diff --git a/tools/circular_dependency_test/index.bzl b/tools/circular_dependency_test/index.bzl
diff --git a/tools/circular_dependency_test/madge-resolve.config.js b/tools/circular_dependency_test/madge-resolve.config.js
diff --git a/yarn.lock b/yarn.lock
