Fix stale active workspace/tab state by syncing stopped sessions#172
Merged
andyrewlee merged 3 commits intomainfrom Feb 19, 2026
Merged
Fix stale active workspace/tab state by syncing stopped sessions#172andyrewlee merged 3 commits intomainfrom
andyrewlee merged 3 commits intomainfrom
Conversation
andyrewlee
commented
Feb 18, 2026
Owner
Author
andyrewlee
left a comment
There was a problem hiding this comment.
✅ Devin Review: No Issues Found
Devin Review analyzed this PR and found no potential bugs to report.
View in Devin Review to see 5 additional findings.
…tate queries Make syncActivitySessionStates a package-level function instead of an App method since the receiver was unused — all data comes via parameters. This makes it explicit the function doesn't touch App state, which matters since it runs inside goroutines. Also add AllSessionStates() to fetch all session states in a single tmux call instead of per-session queries, reducing subprocess overhead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove redundant inner length check on stoppedTabCmds - Replace inline running-like status checks with activity.IsRunningSession - Document syncActivitySessionStates mutation contract at definition and call sites - Add table-driven tests for IsRunningSession (types_test.go) - Add unit tests for syncActivitySessionStates with stubTmuxOps - Add integration tests for AllSessionStates Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the change and intended behavior.
Quality Checklist
make devchecklocally.make lint-strict-newlocally for changed code.make harness-presets.go test ./internal/tmux ./internal/e2e.