Misc. fixes, partly to work with newer Gerrit versions#17
Misc. fixes, partly to work with newer Gerrit versions#17andygrunwald merged 5 commits intoandygrunwald:masterfrom
Conversation
If there are hosts (including a port) defined in ~.ssh/config it is common to only us ethat host's name without a port with SSH. So allow to not specify a port in Gerrie's config. Instead of not setting it, set it explicitly to null so that bootstrapSSHDataService() do esnot stumple over it complaining about an "Undefined index: port".
As Gerrit project namess are case-sensitive, we need to make the database lookup for projects case-sensitive, too.
Gerrit 2.9 deprecated this and related parameters in favor of pagination, see https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.9.html#_changes
|
This changes are looking great. Thank you! |
Misc. fixes, partly to work with newer Gerrit versions
|
Wow, thanks for the fast merge! .-) Note that still more work would be required to get the pagination work with newer versions of Gerrit. These changes only make Gerrie work without throwing an exception, but results may be incomplete. |
|
Thank you for this additional note @sschuberth. At the first view it looks like a "copy" of Gerrie, but it is not. The goal of watson is easier usage (e.g. there is no need for a PHP installation, just download the cross compiled binary and start). Next to this it supports only the REST-API that drops all requirements of setting up a SSH connection directly. Of course, watson is still in development and not production ready yet, but maybe it is interesting for you. |
|
Thanks @andygrunwald for pointing me at watson. If you're saying that Gerrie is more or less deprecated, and you won't add new features (like pagination support) to it, maybe you should say so in the README and include a link to watson, even if watson is not production read yet? |
|
Good point. I added a deprecation notice. See 83c9792 Are they any requests from your side regarding watson? |
|
I don't have any requests regarding watson as I haven't tried it out yet :-) But if so, I'll file an issue over there. Does watson already support Gerrit >= 2.10 style pagination with offsets instead of sort keys? BTW: What was the rational to use Go instead of PHP for watson? (Something that maybe could go into watson's README?) |
|
Hey @sschuberth, sorry for the long outstanding answer.
Afaik, yes it does.
My main reason was that Gerrie is quite hard to deploy for new people (especially the SSH key thingy). With Go a single binary it is "just" download and go. |
Please see the individual commit messages for the details.