Vector async slicing nap#18
Merged
andy-sweet merged 4 commits intoandy-sweet:async-slice-napfrom Jun 29, 2022
Merged
Conversation
andy-sweet
requested changes
Jun 27, 2022
Owner
andy-sweet
left a comment
There was a problem hiding this comment.
Looks great - I just had some minor suggestions around formatting.
Also, you should also add yourself as an author to the doc at the top. Email is optional.
| license [^id3]. Attribution to this source is encouraged where appropriate, as per | ||
| CC0+BY [^id4]. | ||
|
|
||
| ## Related Technical Details |
Owner
There was a problem hiding this comment.
Love these details. Happy to merge them for now. We can think about the best place for them later this week.
Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com>
Author
|
Thanks @andy-sweet! I've made the requested changes. This is ready for review again. |
andy-sweet
approved these changes
Jun 29, 2022
Owner
andy-sweet
left a comment
There was a problem hiding this comment.
Looks great, will merge this now!
andy-sweet
added a commit
that referenced
this pull request
Aug 3, 2022
* Initial commit * Clean up * Start detailed description * Add some notes on shapes layer state. (#17) * Add some notes on shapes layer state. * Update docs/naps/4-async-slicing.md Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com> * Update docs/naps/4-async-slicing.md Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com> * Update docs/naps/4-async-slicing.md Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com> * Update docs/naps/4-async-slicing.md Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com> * Update docs/naps/4-async-slicing.md Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com> * Cleanup of notes on Shapes layer. Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com> * Vector async slicing nap (#18) * add_vector_info * Apply suggestions from code review Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com> * add author Co-authored-by: Kim Pevey <kpevey@quansight.com> Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com> * Some simplification * Update NAP * Revert "Update NAP" This reverts commit e92077c. * Update existing and proposed designs * Add future work and alternatives * Clean up alternatives * Clean formatting. * Pre-PR cleanup * More clean up * Update docs/naps/4-async-slicing.md Co-authored-by: Nicholas Sofroniew <sofroniewn@gmail.com> * Address PR feedback * Update abstract * Clean up abstract * Update motivating video * Signal to event * Add discussion for initial PR Co-authored-by: Eric Perlman <perlman@gmail.com> Co-authored-by: Kim Pevey <kcpevey@quansight.com> Co-authored-by: Kim Pevey <kpevey@quansight.com> Co-authored-by: Nicholas Sofroniew <sofroniewn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
References
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist:
trans.to make them localizable.For more information see our translations guide.