Switched capture strategy directly adding spy appender#3
Merged
andsel merged 3 commits intofeature/string_setting_to_javafrom Nov 12, 2024
Merged
Switched capture strategy directly adding spy appender#3andsel merged 3 commits intofeature/string_setting_to_javafrom
andsel merged 3 commits intofeature/string_setting_to_javafrom
Conversation
…ger's addAppender and a spy appender implementation
andsel
added a commit
that referenced
this pull request
Nov 12, 2024
Reworked log capture in setting_with_deprecated_alias_spec to use Logger's addAppender and a spy appender implementation. This leverages the idea to don't reconfigure the Log4J with a custom build configuration, but simply adding an appender that could spy the appended lines to a logger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked log capture in setting_with_deprecated_alias_spec to use Logger's addAppender and a spy appender implementation.
This leverages the idea to don't reconfigure the Log4J with a custom build configuration, but simply adding an appender that could spy the appended lines to a logger, like described in https://github.com/andsel/log4j2_log_spy?tab=readme-ov-file#idea-2---add-a-customer-appender-to-the-logger-to-collect-the-messages.
The idea is use a list as a message accumulator, but the strange thing is that a message just added disappear and re-appear without an apparent motivation.