Skip to content

Use streaminfo block for FLAC files.#2886

Merged
copybara-service[bot] merged 2 commits into
androidx:mainfrom
Tolriq:flac_fix
Nov 17, 2025
Merged

Use streaminfo block for FLAC files.#2886
copybara-service[bot] merged 2 commits into
androidx:mainfrom
Tolriq:flac_fix

Conversation

@Tolriq

@Tolriq Tolriq commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

Some files do not have the sample size in each frame headers, in that case, ffmpeg needs the streaminfo data to properly decode them.

Issue: #2887

@rohitjoins rohitjoins self-assigned this Nov 11, 2025
@rohitjoins rohitjoins force-pushed the flac_fix branch 3 times, most recently from 6d3645c to 31c1bae Compare November 11, 2025 14:45
@rohitjoins

Copy link
Copy Markdown
Contributor

I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks!

Tolriq and others added 2 commits November 17, 2025 00:51
Some files do not have the sample size in each frame headers, in that case, ffmpeg needs the streaminfo data to properly decode them.
@copybara-service copybara-service Bot merged commit b0c438d into androidx:main Nov 17, 2025
1 check passed
marcbaechinger pushed a commit that referenced this pull request Nov 24, 2025
PiperOrigin-RevId: 833259723
(cherry picked from commit b0c438d)
nift4 pushed a commit to nift4/media that referenced this pull request Dec 27, 2025
@androidx androidx locked and limited conversation to collaborators Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants