This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Refactor the whole project #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/holder/EBeanHolder.java AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/holder/EFragmentHolder.java AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/holder/EViewGroupHolder.java AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/holder/EViewHolder.java
Contributor
Author
|
I have updated my PR and it's ready to be merged ! |
Contributor
|
Great job. I'll review this during the week |
Contributor
|
It's been a while since this PR has been opened. But here we go, I think it's time to merge it :) I'll clean some code later on another commit, but right now... Just great job 👍 |
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to #368.
I finally finished to refactor the project following the model I proposed here.
I changed the structure so the code has just been moved and has been modified as less as possible.
Then, all the tests are passing and the generated code is very often the same as it was before.
Good luck for the review ;)