This repository was archived by the owner on Feb 26, 2023. It is now read-only.
572 enhanced service #601
Merged
572 enhanced service #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssor Refactoring three parts : addCastMethod, addIntentBuilderPutExtraMethod and camelCaseToUpperSnakeCase
Contributor
There was a problem hiding this comment.
To enhance Android Service or Android IntentServices ?
Contributor
|
Hi @DayS, It seems really nice to me appart I didn't see any tests to check I haven't imported the code into my IDE to test this code at runtime. I will do this on next review. |
Contributor
Author
|
To tests this we have to mock the whole Android process to start an IntentService but yes, it's feasible :) |
Contributor
Author
|
You can review the new commits but don't merge the PR yet. I have to do some check in the validator to avoid action name conflicts |
Contributor
Author
|
Ready for review. @mathieuboniface @JoanZapata ? :) |
Conflicts: AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/AndroidAnnotationProcessor.java AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/helper/APTCodeModelHelper.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #572