This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Interpret @Extra annotated params as extras with @Receiver{Action} #1718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| @Receiver(actions = "org.androidannotations.ACTION_1") |
Member
There was a problem hiding this comment.
also a string instead of a constant as in ReceiverWithActions. i think you did that to not polute this PR with extracting the other strings?
Member
|
I think this looks ok just a little extra space that could be removed. |
f916ea1 to
50a27c5
Compare
Member
Author
|
@dodgex thanks, good points. Updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1717 .