This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Upgrade to JCodeModel 2.7.11 #1566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
It is more complicated. Why it is better ?
Member
Author
There was a problem hiding this comment.
It will import just the R class instead of R.string, and fix #1323.
Contributor
|
Is it possible to remove the method in |
Member
Author
|
That method is a thorn in my flesh, but i think we can only achieve that through reflection. |
Member
|
Hey Guys, are there any News on this PR? :) |
Member
Author
|
From my side, it can be merged. @yDelouis ? |
Contributor
|
You're right. We didn't agree about throwing the exception but it's not a big deal. |
Member
Author
|
Yeah, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking advantage of some API changes, as well fixing #1323.