This repository was archived by the owner on Feb 26, 2023. It is now read-only.
1440 rest parameterized type reference #1546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
sadly this can't be merged yet as we have some issues with importing of generic classes e.g. |
Member
|
Good news! I found what was the problem with |
Member
Author
|
This should also fix the multiple imports of the ParameterizedTypeReference. :D |
Member
Author
|
rebased to fix the merge conflict with the ResponseErrorHanlder PR |
Contributor
There was a problem hiding this comment.
You can call getEnvironment directly instead of holder.getEnvironment().
This way, you don't need to give the holder as a parameter of the method.
Contributor
|
It seems okay. Could you address my two comments ? |
Member
Author
|
PR updated |
Generic response class is natively supported in Spring for Android 2.0. This commit utilize that support, if it is available in the reponse class is generic. It falls back to the old implementation otherwise.
yDelouis
added a commit
that referenced
this pull request
Sep 20, 2015
1440 rest parameterized type reference
Contributor
|
Great ! Thanks. |
Member
|
It seems my very important commit was left out. :S |
Member
|
I added that directly to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extension/fix of PR #1467
related to issue #1440