This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Allow subclasses to override @OptionsItem handling #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@yDelouis do you agree? |
537734b to
f4cfed9
Compare
Before this commit onOptionsItemSelected immediately returned if the superclass handled the menu item. From now on, the super call is the last one in the method, so subclasses can ovveride behavior.
f4cfed9 to
b662a2c
Compare
yDelouis
added a commit
that referenced
this pull request
Mar 23, 2015
…ionsItem Allow subclasses to override @OptionsItem handling
Member
Author
|
OK, so it is not a breaking change then. :) |
Contributor
|
It's not mentioned in the doc. So we didn't changed the API but the internal implementation. |
Member
Author
|
This is OK. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1067.
@yDelouis i think this may be a breaking change, as clients could rely on the old behavior in their apps.