This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Improve fix for log file generated #1293
Merged
+9
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Remove the whole constructor as it is empty now.
7bb25f6 to
13d9a0a
Compare
WonderCsabo
added a commit
that referenced
this pull request
Dec 27, 2014
Improve fix for log file generated
Member
There was a problem hiding this comment.
i had kept the constructor but as private and the class as final. as this class should never be instanced from somewhere else than getInstance() or am i wrong? - sorry for late comment but during the holidays i was forced to be afk and was unable to comment :(
Member
There was a problem hiding this comment.
Yeah, this is a singleton class... I'll re-add that right now.
Member
There was a problem hiding this comment.
@dodgex no problem, thanks for mentioning it! I think it is completely ok to be afk on Christmas holidays. 😄
Member
There was a problem hiding this comment.
@WonderCsabo not if you WANT to do some work. ;) but well 🎁 ❤️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as this PR but improved.