-
Notifications
You must be signed in to change notification settings - Fork 2.3k
remove model parameter from @OrmLiteDao #1251
remove model parameter from @OrmLiteDao #1251
Conversation
|
updated the wiki |
|
I think this is a breaking change, so we deprecated the param first. We can |
|
well. the wiki stated that it should have been removed with 3.2. but you can keep the pr open for 4.0. |
|
updated the wiki to 4.0 as removal release |
|
OK, i was in a rush when i edited the wiki, sorry. We cannot remove the param in a minor version, because it will cause compilation errors and that is a breaking change. |
|
I edited the wiki, thanks. |
yeah, for some reasons i had the test project closed in eclipse so i didnt catch that one :D |
|
Can you rebase this branch? |
|
rebased. |
remove model parameter from @OrmLiteDao
|
Thanks. |
|
@dodgex can you update the wiki? |
|
https://github.com/dodgex/androidannotations/wiki/Ormlite i wonder if we want to deprecate |
|
I think it is a good idea. Actually we can just rename since 4.0 is a
breaking release already. @yDelouis WDYT?
|
|
I'm not sure we should rename it. It tells clearly what parameter is expected. |
|
@yDelouis i think you are right. |
|
@dodgex i merged your wiki changes, thanks. |
according to the wiki this should have been gone already. ;)