This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Add @Extra to @Receiver #1181
Merged
Add @Extra to @Receiver #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please do not use vague commit messages as "update test". Explain why do you "update test". :) |
Member
Author
|
@WonderCsabo updated the commit message ;) |
Member
Author
|
wiki is next |
Member
|
Please use |
Member
Author
Member
Author
|
commit messages updated. |
Member
|
I quickly reviewed this and i think this is OK, but i let @yDelouis do the final decisions since he just created the model for these kind of annotations. |
Contributor
|
Thanks ! |
Contributor
|
Related to #1180. |
Member
|
I merged your doc, @dodgex. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
@Extraannotation for@Receiverenhanced methods.@yDelouis: i modified the
ExtraParameterHandlerto accept aJDefinedClass. This allows to create the static fields for the extra key to be generated inside of the anonymousBroadcastReceiverclass. could you review if it is ok how i did it?