This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Clean contentView_ reference in onDestroyView() #1171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If setRetainInstance(true) has been set on the fragment or addToBackStack() was applied to FragmentTransaction, the fragment won't be destroyed and will keep the reference to its parent view in contentView_ and could lead to memory leak. This change implements onDestroyView() which cleans the reference. However, the developer is still responsible for cleaning up the injected views, because otherwise a (badly implemented) background task may get a NullPointerException.
WonderCsabo
added a commit
that referenced
this pull request
Sep 29, 2014
Clean contentView_ reference in onDestroyView()
Member
|
Thanks! |
Author
|
Glad to help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If setRetainInstance(true) has been set on the fragment or
addToBackStack() was applied to FragmentTransaction, the fragment won't be
destroyed and will keep the reference to its parent view in contentView_
and could lead to memory leak.
This change implements onDestroyView() which cleans the reference.
However, the developer is still responsible for cleaning up the injected
views, because otherwise a (badly implemented) background task may get a
NullPointerException.