Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Conversation

@WonderCsabo
Copy link
Member

Lot of system services were missing which are added in newer Android versions. Now AndroidAnnotations support those. Also added tests for all services, and commented out those which cannot be tested due to Android version or Robolectric issues.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This service shouldn't be commented out. We can still manually check that it is injected.
Only the test should be commented out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I comment this out because Robolectric prints messages to System.err about it. But if you think i can re-enable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice. There is indeed a warning in the maven output.
I think we should enable it anyway because it can help us to see if the generated code at least compile.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right.

@yDelouis
Copy link
Contributor

Services not supported by Robolectric should be commented out only in the test class.
We have to be careful and to add only existing services (see my comment about AppWidgetManager).

@WonderCsabo
Copy link
Member Author

I updated the commit. Also i restored alphabetical order.

Lot of system services were missing which are added in newer Android
versions. Now AndroidAnnotations support those. Also added tests for all
services, and commented out those which cannot be tested due to Android
version or Robolectric issues.
@WonderCsabo WonderCsabo force-pushed the addMissingSystemServices branch from 5e8c128 to 1fee3bb Compare September 21, 2014 20:59
@WonderCsabo
Copy link
Member Author

@yDelouis can we merge this?

@yDelouis
Copy link
Contributor

I think so.

WonderCsabo added a commit that referenced this pull request Sep 29, 2014
@WonderCsabo WonderCsabo merged commit 825faa4 into androidannotations:develop Sep 29, 2014
@WonderCsabo WonderCsabo deleted the addMissingSystemServices branch September 29, 2014 16:59
@WonderCsabo WonderCsabo added this to the 3.2 milestone Sep 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants