-
Notifications
You must be signed in to change notification settings - Fork 2.3k
FileAppender in LoggerContext is optional #1110
FileAppender in LoggerContext is optional #1110
Conversation
c9820de to
1445707
Compare
|
@yDelouis this makes a strange "error" and i do not know why. The problem is that the compile-time tests create an androidannotations.log file in the project folder, which has lots of entries. This file has not been created before this PR. |
|
i think this should be merged. while it is not an actual fix for the core issue, it can be a way to workaround the issue for those having issues with a locked logfile. also having open PRs that are ready to merge and having no points against a merge feels bad 😜. so either merge or close. |
|
Yes, i do not like dangling PRs as well! Actually i think this feature can be also useful some people for other reasons. BTW, i just checked the diff and it has syntax highlight now. Awesome! Now i only miss |
|
yeah. might be usefull for other cases to... like disabling the logfile just for the reason that you have not check it ever (like for me^^). i even had to search it in my gradle build directory to find it. |
Logging to the file now can be turned off in annotation processing options. It is still on by default.
1445707 to
87ac006
Compare
FileAppender in LoggerContext is optional
|
Seems good to me. |
|
Done. |
|
@yDelouis this has a regression: when running the compile-time tests, the |
Logging to the file now can be turned off in annotation processing options. It is still on by default.
This provides a workaround for #961.