Thanks for this! BTW, all the other enhanced components can work with generics?

I checked code for the same issues and didn't find them. But it is possible
that there are another problems with generics, especially in fragments and
activities. Maybe we just need to write tests to figure it out )))

Right. Fragments, Activities and some other components have generated
builders. Good place for generics issues.

I just tried it out:

• Activity: There are no compilation problems, the generated class is generic.
• Fragment: The class is OK as with Activities, but the FragmentBuilder is totally messed up.
• Service: OK.

OK. Let's create another issue for fragments. I'll try to find the time to
fix it.
29 июля 2014 г. 2:24 пользователь "Csaba Kozák" notifications@github.com
написал:

I just tried it out:

• Activity: There is no compilation problems, the generated class is
  generic.
• Fragment: The class is OK as with Activities, but the
  FragmentBuilder is totally messed up.
• Service: OK.

—
Reply to this email directly or view it on GitHub
#1075 (comment)
.

Thanks @Artyomcool, really appreciated! I created #1077.

You are using space indentation instead of tabs. Please use the formatting settings provided with the projects.

Multiple files are missing the license header. Please add them by executing mvn license:format in the parent project.

@WonderCsabo, I've added a license headers here, and in #1117 for classes created by me. As for tabs and spaces there is a problem. I'm using an Intellij Idea as IDE, so, your settings file can't be used directly. If I'll just reformat hole code with tabs, I'm pretty sure, that I'll break the rest formating, like imports order and so on. Could you provide settings for Intellij Idea? Or maybe just do it for me? In this case, I'll be more carefull next time.

Yeah, we already had problems about IDEA, unfortunetaly importing the eclipse prefs do not work. I want to add checkstyle to the build so at least the build fails with basic errors in formatting.

About rebasing: i do not like commits like "reformat code", this looks really dumb in commit history. Your formatting is ok, so if you can just replace spaces with tabs and squash this into a single commit, that would be great. The same applies to the other PR.

Ok, I'll do it by reset --mixed. In this way I'll be able to see, what code was changed and reformat it localy.

Thanks. Please note that i would do that work for you but i cannot merge modified commits by me, because in that case GH does not marks the PR as merged, and we list contributors and changes in release notes from merged PRs.

I think, the best way to resolve code style issue - is to make me do it :) It is not because of contributors list - I'm actually don't care about. But it is the only way to remember, that I should respect and follow your code style.

Thanks. I am sorry, but i have another request, which is in contrast to my previous one. I did not know that you have wrong formatting in the other files, it seems @DayS did not recognized when he reviewed. Can i ask you to separate these formattings to another commit, since these has nothing to do with generic @EViewGroup?

Can you add a compile-time test with generic ViewGroup?

Edit: I just realized that you had tests in your previous commit. It seems you unintentionally removed those. I still have them in my local repo, so i can push them to be available, but i think you can also find those in your reflog.

Could you pin point, where should I fix the formatting?

Maybe my request was not clear. You have changed SupposeBackgroundHandler, SupposeThreadHandler and SupposeUiThreadHandler in commit dd6987d. This commit is about fixing generic issues in ViewGroups, so the formatting changes you made should be in a separate commit.

I know i said i do not like commits like "formatting", but in this case we cannot do anything else, since the wrong formatted code is already pushed to develop.

If someone will face the same problem with indentation, I could share my experience. It can be easely fixed step-by-step for IDEA:

1. File->Settings
2. Code Style->Java->Tabs and Indents
3. Check "Use tab character"
4. Use git reset --mixed HEADN, where N is number of commits to fix and squashm e.g. HEAD1
5. Commit through IDE: Right click on the project -> Git -> Commit directory...
6. Check "Reformat code"
7. Commit
8. Push with --force option

It will reformat only changed code, so it should not break the rest of formatitng.

Repushed without reformating the SupposeThread feature.

I'll add requested tests a little bit later, I need some time to fix all issues with formating :)

Open another PR for reformatting the other files, then, so we are really clear with intents of PRs and commits.

Right.

Done: #1119

As for tests - could you add it from your local repo? It will be much faster, then searching through reflog.

You can find those in this branch. Actually i refetched your repo so i had to search my reflog. :)

BTW, there are some updates in the instruction for code contributors, please read them.

I've done a lot of resets today, so it was tricky to find the tests. I still don't know when I lost them, but now the are restored and everything squashed into a single commit.

@dodgex Thanks for all your work and for doing all my annoying requests! You did a great job on generics handling in AA.

@yDelouis This PR is ready to be merged, but it will miss 3.1 if we release that very soon.

@WonderCsabo while i'm happy that you are thanking me, i think you should thank @Artyomcool in this PR ;)

@WonderCsabo, @dodgex also did a great work for AA, but not generic issues ;)

Sorry. It seems i should do less things in parallel... So thanks, @Artyomcool for the generic stuff. :)

And thank you, guys, for a great framework.
BTW: somewhere should be a place, where contributers could peek an issue to do next, what do you think?

@Artyomcool i think we can agree that we both (and all other contributors) did great work. ;) its work worth it, as AA takes the work from us on other places. :)

@Artyomcool try this or this or simply this ;) at least thats what i did. :p

contributers could peek an issue to do next

You mean "pick" an issue? In the past @DayS added the milestones for every proposed feature which has been accepted to be a good one. So you can look at those lists what @dodgex referenced. We want to change the release model of AA to get more frequent releases and maybe more motivation to do the features, so perhaps these milestones will be dropped. Since this is not related to this PR, we should really talk about this in the mailing list.

Finally merged. Thanks.