Update SPDX tools-golang lib to v0.5.0#1503
Merged
kzantow merged 3 commits intoanchore:mainfrom Jan 31, 2023
Merged
Conversation
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Contributor
|
@kzantow This looks good - are we waiting on a retag or any other functionality? |
Contributor
Author
|
I'm going to do a bit more manual testing to see if I can find any cases we didn't cover properly in tests and take it out of draft when I think things are ready. |
spiffcs
approved these changes
Jan 31, 2023
Contributor
spiffcs
left a comment
There was a problem hiding this comment.
All the tests pass and from my perspective most of the updates in the PR are the library changes common ==> spdx
LGTM
If there is other testing you want done or edge cases to call out let me know, but I think we can get this in and release
|
|
||
| "github.com/spdx/tools-golang/spdx/common" | ||
| spdx "github.com/spdx/tools-golang/spdx/v2_3" | ||
| "github.com/spdx/tools-golang/spdx" |
|
|
||
| func decoder(reader io.Reader) (*sbom.SBOM, error) { | ||
| doc, err := tvloader.Load2_3(reader) | ||
| doc, err := tagvalue.Read(reader) |
This was referenced Jan 31, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates spdx/tools-golang to v0.5.0 (-rc1).