Skip to content

Updated dependencies#3

Merged
analog-nico merged 3 commits intoanalog-nico:masterfrom
maxrimue:updated-dependencies
May 24, 2015
Merged

Updated dependencies#3
analog-nico merged 3 commits intoanalog-nico:masterfrom
maxrimue:updated-dependencies

Conversation

@maxrimue
Copy link
Copy Markdown
Contributor

First of all: Thanks for creating this project.
I've been using it in one of my repos, however, when using david-dm it showed me that my dependencies are "Insecure". I think this is related to hpp, because it uses outdated modules. This change should just update the dependencies, everything should work as expected, since those are just minor updates, so updates not changing or removing any existing API.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 52d152d on maxrimue:updated-dependencies into c2be807 on analog-nico:master.

@maxrimue
Copy link
Copy Markdown
Contributor Author

Seems like it's failing for 0.10.0, could this be because of the devDependencies?

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling dcea4d0 on maxrimue:updated-dependencies into c2be807 on analog-nico:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling dcea4d0 on maxrimue:updated-dependencies into c2be807 on analog-nico:master.

@maxrimue
Copy link
Copy Markdown
Contributor Author

There we go. It seems like something was wrong with the coveralls plugin

@analog-nico
Copy link
Copy Markdown
Owner

Hi @maxrimue thanks for working on this!

Thanks to your PR I checked http://semver.org for the first time and OMG I always had a wrong understanding of semantic versioning!

To make sure people don't risk to install a too old dependency would you mind changing all versions - e.g. for lodash - from 3.x.x to ^3.8?

I can afterwards configure TravisCI to build with lodash 3.8.0 + type-is 1.6.0 and also with lodash latest + type-is latest.

@maxrimue
Copy link
Copy Markdown
Contributor Author

@analog-nico Do you explicitly want lodash in version 3.8 or higher, or can it be also 3.9 or higher?

@analog-nico
Copy link
Copy Markdown
Owner

Good point. Take the highest version available today.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling bc67157 on maxrimue:updated-dependencies into c2be807 on analog-nico:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling bc67157 on maxrimue:updated-dependencies into c2be807 on analog-nico:master.

@maxrimue
Copy link
Copy Markdown
Contributor Author

Done

analog-nico added a commit that referenced this pull request May 24, 2015
@analog-nico analog-nico merged commit c4066c6 into analog-nico:master May 24, 2015
@maxrimue maxrimue deleted the updated-dependencies branch May 24, 2015 16:35
@analog-nico
Copy link
Copy Markdown
Owner

Hi @maxrimue I just published version 0.2.0 with it's dependencies up-to-date. Cheers!

@maxrimue
Copy link
Copy Markdown
Contributor Author

@analog-nico Glad to hear that, thanks 👍

@spectrum-bot spectrum-bot mentioned this pull request Apr 23, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants