Skip to content

refactor internal modules#149

Merged
amtoine merged 10 commits intonightlyfrom
refactor
Dec 18, 2023
Merged

refactor internal modules#149
amtoine merged 10 commits intonightlyfrom
refactor

Conversation

@amtoine
Copy link
Copy Markdown
Owner

@amtoine amtoine commented Dec 16, 2023

should

description

before

pkgs/nu-git-manager/
|-- nu-git-manager
|   |-- completions
|   |   `-- nu-complete.nu
|   |-- error
|   |   `-- error.nu
|   |-- fs
|   |   |-- cache.nu
|   |   |-- dir.nu
|   |   |-- path.nu
|   |   `-- store.nu
|   |-- git
|   |   |-- repo.nu
|   |   `-- url.nu
|   `-- mod.nu
|-- nupm.nuon
`-- tests
    |-- gm.nu
    `-- mod.nu
pkgs/nu-git-manager-sugar/
|-- nu-git-manager-sugar
|   |-- completions
|   |   `-- nu-complete.nu
|   |-- extra.nu
|   |-- git
|   |   |-- lib
|   |   |   |-- lib.nu
|   |   |   |-- prompt.nu
|   |   |   `-- style.nu
|   |   |-- mod.nu
|   |   `-- prompt.nu
|   |-- github.nu
|   `-- mod.nu
|-- nupm.nuon
`-- tests
    |-- git.nu
    `-- mod.nu

after

Important
caveats:

  • [1]: has use path.nu ... instead of use path
  • [2]: has use style.nu ... instead of use style
pkgs/nu-git-manager/
|-- nu-git-manager
|   |-- completions.nu    # internal
|   |-- error.nu          # internal
|   |-- fs                # internal
|   |   |-- cache.nu   [1]
|   |   |-- dir.nu     [1]
|   |   |-- mod.nu
|   |   |-- path.nu
|   |   `-- store.nu   [1]
|   |-- git               # internal
|   |   |-- mod.nu
|   |   |-- repo.nu
|   |   `-- url.nu
|   `-- mod.nu
|-- nupm.nuon
`-- tests
    |-- gm.nu
    `-- mod.nu
pkgs/nu-git-manager-sugar/
|-- nu-git-manager-sugar
|   |-- completions.nu        # internal
|   |-- extra.nu              # public
|   |-- git                   # public
|   |   |-- lib               #     internal
|   |   |   |-- git.nu     [2]#         public
|   |   |   |-- mod.nu
|   |   |   |-- prompt.nu     #         public
|   |   |   `-- style.nu   [2]#         public
|   |   |-- mod.nu
|   |   `-- prompt.nu         #     public
|   |-- github.nu             # public
|   `-- mod.nu
|-- nupm.nuon
`-- tests
    |-- git.nu
    `-- mod.nu

TODO

  • nu-git-manager-sugar/git/lib issue with prompt.nu in 77596ff

@amtoine amtoine added nightly A bleeding edge change refactor Changes that just moves code around without altering features labels Dec 16, 2023
@amtoine amtoine changed the title refactor refactor internal modules Dec 16, 2023
@amtoine amtoine marked this pull request as ready for review December 18, 2023 11:29
@amtoine amtoine merged commit cb591b8 into nightly Dec 18, 2023
@amtoine amtoine deleted the refactor branch December 18, 2023 11:43
amtoine added a commit that referenced this pull request Jan 21, 2024
should
- close #85
 
## description
### before
```
pkgs/nu-git-manager/
|-- nu-git-manager
|   |-- completions
|   |   `-- nu-complete.nu
|   |-- error
|   |   `-- error.nu
|   |-- fs
|   |   |-- cache.nu
|   |   |-- dir.nu
|   |   |-- path.nu
|   |   `-- store.nu
|   |-- git
|   |   |-- repo.nu
|   |   `-- url.nu
|   `-- mod.nu
|-- nupm.nuon
`-- tests
    |-- gm.nu
    `-- mod.nu
```
```
pkgs/nu-git-manager-sugar/
|-- nu-git-manager-sugar
|   |-- completions
|   |   `-- nu-complete.nu
|   |-- extra.nu
|   |-- git
|   |   |-- lib
|   |   |   |-- lib.nu
|   |   |   |-- prompt.nu
|   |   |   `-- style.nu
|   |   |-- mod.nu
|   |   `-- prompt.nu
|   |-- github.nu
|   `-- mod.nu
|-- nupm.nuon
`-- tests
    |-- git.nu
    `-- mod.nu
```

### after
> **Important**
>  caveats:
> - `[1]`: has `use path.nu ...` instead of `use path`
> - `[2]`: has `use style.nu ...` instead of `use style`

```
pkgs/nu-git-manager/
|-- nu-git-manager
|   |-- completions.nu    # internal
|   |-- error.nu          # internal
|   |-- fs                # internal
|   |   |-- cache.nu   [1]
|   |   |-- dir.nu     [1]
|   |   |-- mod.nu
|   |   |-- path.nu
|   |   `-- store.nu   [1]
|   |-- git               # internal
|   |   |-- mod.nu
|   |   |-- repo.nu
|   |   `-- url.nu
|   `-- mod.nu
|-- nupm.nuon
`-- tests
    |-- gm.nu
    `-- mod.nu
```
```
pkgs/nu-git-manager-sugar/
|-- nu-git-manager-sugar
|   |-- completions.nu        # internal
|   |-- extra.nu              # public
|   |-- git                   # public
|   |   |-- lib               #     internal
|   |   |   |-- git.nu     [2]#         public
|   |   |   |-- mod.nu
|   |   |   |-- prompt.nu     #         public
|   |   |   `-- style.nu   [2]#         public
|   |   |-- mod.nu
|   |   `-- prompt.nu         #     public
|   |-- github.nu             # public
|   `-- mod.nu
|-- nupm.nuon
`-- tests
    |-- git.nu
    `-- mod.nu
```

## TODO
- [x] `nu-git-manager-sugar/git/lib` issue with `prompt.nu` in
77596ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nightly A bleeding edge change refactor Changes that just moves code around without altering features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant